fix to coderabbit's qa

kaeizen · kaeizen · commit 49426046a6a5 · 2025-09-24T20:30:16.000+08:00
diff --git a/src/components/design-library-list/design-library-list-item.js b/src/components/design-library-list/design-library-list-item.js
@@ -62,7 +62,7 @@ const DesignLibraryListItem = props => {
 
 	const getCardHeight = () => {
 		const key = props.enableBackground ? 'background' : 'noBackground'
-		return cardHeight?.[ key ] || ( props.selectedTab === 'pages' ? 413 : 250 )
+		return cardHeight?.[ key ] ?? ( props.selectedTab === 'pages' ? 413 : 250 )
 	}
 
 	if ( ! shouldRender && ! props.selectedNum ) {
diff --git a/src/components/design-library-list/design-preview.js b/src/components/design-library-list/design-preview.js
@@ -84,16 +84,17 @@ export const DesignPreview = ( {
 	useEffect( () => {
 		const wrapper = wrapperRef.current
 
-		if ( ! wrapper ) {
+		if ( ! wrapper || ! blocks ) {
 			return
 		}
 
-		const ric = window.requestIdleCallback || window.requestAnimationFrame
+		const ric = window.requestIdleCallback || ( cb => setTimeout( cb, designIndex * 20 ) )
 		const sanitizedHTML = safeHTML( blocks )
 
 		if ( selectedTab !== 'pages' || designIndex < 9 ) {
 			// insert HTML for patterns and for the first 9 pages
 			wrapper.innerHTML = sanitizedHTML
+			// No need to call setIsLoading(false) here; isLoading is already false at this point.
 			return
 		}
 
@@ -108,7 +109,7 @@ export const DesignPreview = ( {
 				} )
 			} )
 		} )
-	}, [ blocks ] )
+	}, [ blocks ] ) // Only depend on blocks; selectedTab and designIndex changes will cause blocks to update
 
 	return createPortal( <>
 		<body
diff --git a/src/components/design-library-list/index.js b/src/components/design-library-list/index.js
@@ -101,7 +101,7 @@ const DesignLibraryItem = props => {
 			id = requestIdleCallback( () => setShouldRender( true ) )
 		} else {
 			// fallback
-			id = setTimeout( () => setShouldRender( true ), 0 )
+			id = setTimeout( () => setShouldRender( true ), props.designIndex * 20 )
 		}
 
 		return () => {

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ const DesignLibraryListItem = props => {`
`62`	`62`
`63`	`63`	`const getCardHeight = () => {`
`64`	`64`	`const key = props.enableBackground ? 'background' : 'noBackground'`
`65`		`- return cardHeight?.[ key ] \|\| ( props.selectedTab === 'pages' ? 413 : 250 )`
	`65`	`+ return cardHeight?.[ key ] ?? ( props.selectedTab === 'pages' ? 413 : 250 )`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`if ( ! shouldRender && ! props.selectedNum ) {`
Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ const DesignLibraryItem = props => {`
`101`	`101`	`id = requestIdleCallback( () => setShouldRender( true ) )`
`102`	`102`	`} else {`
`103`	`103`	`// fallback`
`104`		`- id = setTimeout( () => setShouldRender( true ), 0 )`
	`104`	`+ id = setTimeout( () => setShouldRender( true ), props.designIndex * 20 )`
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`return () => {`