Skip to content

Commit 52cde3d

Browse files
committed
fix to code rabbit's qa
1 parent 0de30d8 commit 52cde3d

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

src/components/design-library-list/design-preview.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,13 +86,17 @@ export const DesignPreview = ( {
8686
return
8787
}
8888

89+
const ric = window.requestIdleCallback || window.requestAnimationFrame
90+
const sanitizedHTML = safeHTML( blocks )
91+
8992
if ( selectedTab !== 'pages' ) {
90-
wrapper.innerHTML = safeHTML( blocks )
93+
wrapper.innerHTML = sanitizedHTML
94+
return
9195
}
9296

9397
requestAnimationFrame( () => {
94-
requestIdleCallback( () => {
95-
wrapper.innerHTML = safeHTML( blocks )
98+
ric( () => {
99+
wrapper.innerHTML = sanitizedHTML
96100
updateShadowBodySize()
97101
} )
98102
} )

src/components/design-library-list/use-preview-renderer.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ export const usePreviewRenderer = (
128128
setPreviewSize( prev => {
129129
const newPreviewSize = { ...prev, scale: scaleFactor }
130130

131-
if ( Object.keys( prev ).length === 1 ) {
131+
if ( Object.keys( prev ).length === 0 ) {
132132
newPreviewSize.heightBackground = _height
133133
newPreviewSize.heightNoBackground = _height
134134
} else {
@@ -231,6 +231,11 @@ export const usePreviewRenderer = (
231231
return
232232
}
233233

234+
// Reset per-template state and show spinner
235+
setIsLoading( true )
236+
categoriesRef.current = []
237+
hasBackgroundTargetRef.current = false
238+
234239
let _parsedBlocks = []
235240
let _parsedBlocksForInsertion = null
236241
const initialize = async () => {

0 commit comments

Comments
 (0)