Skip to content

Commit 5b9541b

Browse files
committed
fix coderabbit's qa
1 parent 7a7a167 commit 5b9541b

File tree

4 files changed

+16
-8
lines changed

4 files changed

+16
-8
lines changed

src/components/design-library-list/editor.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,8 @@
6060
}
6161
&.ugb--is-hidden {
6262
opacity: 0;
63+
pointer-events: none;
64+
visibility: hidden;
6365
}
6466
footer {
6567
line-height: 18px;

src/components/design-library-list/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ const DesignLibraryItem = memo( props => {
9191
const selectedData = selectedNum ? selectedDesignData[ selectedNum - 1 ] : null
9292

9393
return { selectedNum, selectedData }
94-
}, [ selectedDesignIds ] )
94+
}, [ selectedDesignIds, selectedDesignData ] )
9595

9696
const previewProps = useMemo( () => ( {
9797
designId: design.id || design.designId,

src/components/modal-design-library/header-actions.js

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,16 @@ import {
1919

2020
import { __ } from '@wordpress/i18n'
2121

22-
const PLAN_OPTIONS = [ { key: '', label: __( 'All', i18n ) }, { key: 'free', label: __( 'Free', i18n ) }, { key: 'premium', label: __( 'Premium', i18n ) } ]
22+
export const PLAN_OPTIONS = [ { key: '', label: __( 'All', i18n ) }, { key: 'free', label: __( 'Free', i18n ) }, { key: 'premium', label: __( 'Premium', i18n ) } ]
2323

2424
export const HeaderActions = props => {
2525
const {
26-
selectedTab, setSelectedTab, selectedPlan, setSelectedPlan, setDoReset,
26+
selectedTab,
27+
setSelectedTab,
28+
selectedPlan,
29+
setSelectedPlan,
30+
setDoReset,
31+
onClose,
2732
} = props
2833
return <>
2934
{ /* DEV NOTE: hide for now */ }
@@ -54,9 +59,9 @@ export const HeaderActions = props => {
5459
onChange={ value => {
5560
localStorage.setItem( 'stk__design_library__dev_mode', value ? '1' : '' )
5661
setTimeout( () => {
57-
document?.querySelector( '.ugb-insert-library-button__wrapper .ugb-insert-library-button' ).click()
62+
document?.querySelector( '.ugb-insert-library-button__wrapper .ugb-insert-library-button' )?.click()
5863
}, 100 )
59-
props.onClose()
64+
onClose()
6065
} }
6166
__nextHasNoMarginBottom
6267
/>

src/components/modal-design-library/modal.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ import { useBlockColorSchemes } from '~stackable/hooks'
3434
import ColorSchemePreview from '../color-scheme-preview'
3535
import { ColorSchemesHelp } from '../color-schemes-help'
3636
import Tooltip from '../tooltip'
37-
import { HeaderActions } from './header-actions'
37+
import { HeaderActions, PLAN_OPTIONS } from './header-actions'
3838

3939
const popoverProps = {
4040
className: 'ugb-design-library__color-scheme-popover',
@@ -66,7 +66,7 @@ export const ModalDesignLibrary = props => {
6666

6767
const [ selectedTab, setSelectedTab ] = useLocalStorage( 'stk__design_library__block-list__view_by', 'patterns' )
6868
const [ selectedCategory, setSelectedCategory ] = useLocalStorage( 'stk__design_library__block-list__selected', '' )
69-
const [ selectedPlan, setSelectedPlan ] = useLocalStorage( 'stk__design_library__view-plan', '' )
69+
const [ selectedPlan, setSelectedPlan ] = useLocalStorage( 'stk__design_library__view-plan', PLAN_OPTIONS[ 0 ] )
7070

7171
// The sidebar designs are used to update the list of blocks in the sidebar.
7272
const [ sidebarDesigns, setSidebarDesigns ] = useState( [] )
@@ -181,8 +181,9 @@ export const ModalDesignLibrary = props => {
181181
selectedPlan={ selectedPlan }
182182
setSelectedPlan={ setSelectedPlan }
183183
setDoReset={ setDoReset }
184+
onClose={ props.onClose }
184185
/>
185-
}, [ selectedTab ] )
186+
}, [ selectedTab, selectedPlan, setSelectedTab, setSelectedPlan, setDoReset, props.onClose ] )
186187

187188
// Memoize the context value to prevent unnecessary rerenders
188189
const contextValue = useMemo(

0 commit comments

Comments
 (0)