use add_filter directly

Author: kaeizen

src/welcome/useful-plugins.php

@@ -25,19 +25,6 @@ class Stackable_Useful_Plugins {
 		);
 
 		function __construct() {
-			// Register action on 'admin_menu' to ensure filters for the editor and admin settings
-			// are added early, before those scripts are enqueued and filters are applied.
-			// Only add this action if we're on the useful plugins page or post.php
-			global $pagenow;
-
-			$page = isset( $_GET['page'] ) ? sanitize_text_field( $_GET['page'] ) : '';
-			$is_useful_plugins_page = ( $page === 'stackable-useful-plugins' );
-			$is_post_editor = ( $pagenow === 'post.php' );
-
-			if ( $is_useful_plugins_page || $is_post_editor ) {
-				add_action( 'admin_menu', array( $this, 'get_useful_plugins_info' ) );
-			}
-
 			// use WordPress ajax installer
 			// see Docs: https://developer.wordpress.org/reference/functions/wp_ajax_install_plugin/
 			add_action('wp_ajax_stackable_useful_plugins_activate', array( $this, 'do_plugin_activate' ) );
@@ -47,6 +34,13 @@ function __construct() {
 			add_action('wp_ajax_stackable_check_cimo_status', array( $this, 'check_cimo_status' ) );
 
 			if ( is_admin() ) {
+				add_filter( 'stackable_localize_settings_script', function ( $args ) {
+					return $this->get_useful_plugins_info( $args, array( $this, 'add_args_to_localize_admin' ) );
+				} );
+				add_filter( 'stackable_localize_script', function ( $args ) {
+					return $this->get_useful_plugins_info( $args, array( $this, 'add_cimo_args_to_localize_editor' ),
+					[ 'cimo-image-optimizer' => self::$PLUGINS[ 'cimo-image-optimizer' ] ] );
+				}, 1 );
 				add_filter( 'stackable_localize_script', array( $this, 'localize_hide_cimo_notice' ) );
 			}
 		}
@@ -77,7 +71,11 @@ public static function is_plugin_activated( $plugin_slug ) {
 		}
 
 
-		public function get_useful_plugins_info() {
+		public function get_useful_plugins_info( $args, $callback, $plugin_config = null ) {
+			if ( $plugin_config === null ) {
+				$plugin_config = self::$PLUGINS;
+			}
+
 			$current_user_cap = current_user_can( 'install_plugins' ) ? 2 : (
 				current_user_can( 'activate_plugins') ? 1 : 0
 			);
@@ -94,7 +92,7 @@ public function get_useful_plugins_info() {
 			$data_to_localize = array();
 
 			$has_premium = false;
-			foreach ( self::$PLUGINS as $key => $plugin ) {
+			foreach ( $plugin_config as $key => $plugin ) {
 				$status = 'not_installed';
 				$full_slug_to_use = $plugin['full_slug'];
 
@@ -132,13 +130,12 @@ public function get_useful_plugins_info() {
 				);
 			}
 
-			// Make Cimo available in the block editor
-			$this->add_cimo_args_to_localize_editor( $data_to_localize, $current_user_cap, $has_premium );
-			// Make all plugin data and the ajax url available in the admin settings
-			$this->add_args_to_localize_admin( $data_to_localize );
+			$args = call_user_func( $callback, $args, $data_to_localize, $current_user_cap, $has_premium );
+
+			return $args;
 		}
 
-		public function add_cimo_args_to_localize_editor( $data_to_localize, $current_user_cap, $has_premium ) {
+		public function add_cimo_args_to_localize_editor( $args, $data_to_localize, $current_user_cap, $has_premium ) {
 			$slug = 'cimo-image-optimizer';
 			if ( ! isset( $data_to_localize[ $slug ] ) ) {
 				return;
@@ -173,23 +170,18 @@ public function add_cimo_args_to_localize_editor( $data_to_localize, $current_us
 
 			$cimo_data[ 'action' ] = html_entity_decode( $action_link );
 
-			add_filter( 'stackable_localize_script', function ( $args ) use( $cimo_data ) {
-				return $this->add_localize_script( $args, 'cimo', $cimo_data );
-			}, 1 );
-
+			return $this->add_localize_script( $args, 'cimo', $cimo_data );
 		}
 
-		public function add_args_to_localize_admin( $data_to_localize ) {
+		public function add_args_to_localize_admin( $args, $data_to_localize ) {
 			$argsToAdd = array(
 				'usefulPlugins' => $data_to_localize,
 				'installerNonce' => wp_create_nonce( "updates" ),
 				'activateNonce' => wp_create_nonce( "stk_activate_useful_plugin" ),
 				'ajaxUrl' => admin_url('admin-ajax.php')
 			);
 
-			add_filter( 'stackable_localize_settings_script', function ( $args ) use( $argsToAdd ) {
-				return $this->add_localize_script( $args, '', $argsToAdd );
-			} );
+			return $this->add_localize_script( $args, '', $argsToAdd );
 		}
 
 		public function add_localize_script( $args, $arg_key, $data ) {