fix: cascade by repeatedly checking if disabled

Author: Arukuen

src/block/design-library/edit.js

@@ -34,48 +34,28 @@ import { useBlockProps } from '@wordpress/block-editor'
 // Replaces the current block with a block made out of attributes.
 const createBlockWithAttributes = ( blockName, attributes, innerBlocks, design ) => {
 	const disabledBlocks = settings.stackable_block_states || {} // eslint-disable-line camelcase
-	const nonSubstitutableBlocks = new Set()
 
 	// Recursively substitute core blocks to disabled Stackable blocks
 	const traverseBlocksAndSubstitute = blocks => {
 		return blocks.map( block => {
-			let [ blockName, blockAttributes, innerBlocks ] = block
-
-			if ( innerBlocks && innerBlocks.length > 0 ) {
-				innerBlocks = traverseBlocksAndSubstitute( innerBlocks )
+			if ( block[ 2 ] && block[ 2 ].length > 0 ) {
+				block[ 2 ] = traverseBlocksAndSubstitute( block[ 2 ] )
 			}
 
-			const substituted = substituteCoreIfDisabled( blockName, blockAttributes, innerBlocks, substitutionRules )
-			const blockType = getBlockType( blockName )
-
-			// Get the disabled non-substitutable blocks
-			if ( ! ( blockName in substitutionRules ) &&
-				( ! blockType || blockType[ 'stk-cannot-be-disabled' ] !== true ) &&
-				blockName in disabledBlocks &&
-				disabledBlocks[ blockName ] === BLOCK_STATE.DISABLED
-			) {
-				nonSubstitutableBlocks.add( blockName )
+			// Check if the new substituted block is still disabled
+			while ( block[ 0 ] in disabledBlocks && disabledBlocks[ block[ 0 ] ] === BLOCK_STATE.DISABLED ) {
+				block = substituteCoreIfDisabled( ...block, substitutionRules )
 			}
 
-			if ( ! Array.isArray( substituted[ 2 ] ) ) {
-				substituted[ 2 ] = []
+			if ( ! Array.isArray( block[ 2 ] ) ) {
+				block[ 2 ] = []
 			}
-			return substituted
+			return block
 		} )
 	}
 
 	innerBlocks = traverseBlocksAndSubstitute( innerBlocks )
 
-	// Warn the user which blocks are needed to be enabled
-	if ( nonSubstitutableBlocks.size > 0 ) {
-		// eslint-disable no-console
-		console.warn( // eslint-disable-line no-console
-			`The selected design requires the following block(s) to be enabled for it to function properly:\n\n` +
-			`${ Array.from( nonSubstitutableBlocks ).join( '\n' ) }`
-		)
-		// eslint-enable no-console
-	}
-
 	// const { replaceBlock } = dispatch( 'core/block-editor' )
 
 	// For wireframes, we'll need to apply any default block attributes to