fix error handling for image download/upload

Author: kaeizen

src/block/design-library/edit.js

@@ -59,18 +59,22 @@ const checkIfImageUrl = async value => {
 	const matches = attributeUrl.pathname.match( /\/([^/]+\.(jpe?g|gif|png|mp4|webp))$/i )
 
 	if ( matches ) {
-		const result = await apiFetch( {
-			path: '/stackable/v3/design_library_image',
-			method: 'POST',
-			// eslint-disable-next-line camelcase
-			data: { image_url: attributeUrl.href },
-		} )
-		if ( result.success ) {
-			return result.new_url
+		try {
+			const result = await apiFetch( {
+				path: '/stackable/v3/design_library_image',
+				method: 'POST',
+				// eslint-disable-next-line camelcase
+				data: { image_url: attributeUrl.href },
+			} )
+			if ( result.success ) {
+				return result.new_url
+			}
+			console.error( 'Stackable Design Library:', result.message ) // eslint-disable-line no-console
+			return value
+		} catch ( error ) {
+			console.error( 'Stackable Design Library:', error.message ) // eslint-disable-line no-console
+			return value
 		}
-
-		console.error( 'Stackable Design Library:', result.message ) // eslint-disable-line no-console
-		return value
 	}
 	return value
 }

src/design-library/init.php

@@ -179,14 +179,15 @@ public function get_design_library_image( $request ) {
 			if ( is_wp_error( $temp_filepath ) ) {
 				return new WP_REST_Response( array(
 					'success' => false,
-					'message' => 'Failed to retrieve image from the provided URL.'
+					'message' => $temp_filepath->get_error_message()
 				), 500 );
 			}
 
 			if ( ! file_exists( $temp_filepath ) || ! wp_filesize( $temp_filepath ) ) {
-				@unlink( $temp_filepath );
+				wp_delete_file( $temp_filepath );
 				return new WP_REST_Response( array(
 					'success' => false,
+					// This is a custom check so we return a custom error message.
 					'message' => 'Invalid file content retrieved from the provided URL.'
 				), 400 );
 			}
@@ -205,9 +206,10 @@ public function get_design_library_image( $request ) {
 					&& ! wp_getimagesize( $temp_filepath )
 				)
 			) {
-				@unlink( $temp_filepath );
+				wp_delete_file( $temp_filepath );
 				return new WP_REST_Response( array(
 					'success' => false,
+					// This is a custom check so we return a custom error message.
 					'message' => 'The file is not a valid image/video.'
 				), 400 );
 			}
@@ -219,13 +221,13 @@ public function get_design_library_image( $request ) {
 			) );
 
 			if ( file_exists( $temp_filepath ) ) {
-				@unlink( $temp_filepath );
+				wp_delete_file( $temp_filepath );
 			}
 
 			if ( is_wp_error( $media_id ) ) {
 				return new WP_REST_Response( array(
 					'success' => false,
-					'message' => 'An error occured during media upload.'
+					'message' =>  $media_id->get_error_message()
 				), 500 );
 			}