test

Author: Ang-dot

.github/workflows/validate-new-plugin-metadata.yml

@@ -81,37 +81,54 @@ jobs:
           check_valid_url() {
             local field="$1"
             local required="${2:-optional}"  # Default to "optional" if no second parameter is provided
-            local value=$(echo "$metadata" | yq ".$field" || true)
+            local value
+            value=$(echo "$metadata" | yq -r ".$field" || true)
 
             # If field is missing or empty
-            if [[ -z "$value" ]]; then
+            if [[ -z "$value" || "$value" == "null" ]]; then
               if [[ "$required" == "required" ]]; then
                 echo "::error file=$metadata_file::'$field' is required but missing"
                 ((errors++))
               fi
               return 0  # Skip validation if it's optional and missing
             fi
 
-            # Handle arrays of URLs (e.g., screenshots)
-            # Check if the field is an array using yq length check
-            is_array=$(echo "$metadata" | yq -r ".${field} | length")
-            
-            if [[ "$is_array" =~ ^[0-9]+$ && "$is_array" -gt 0 ]]; then
-              # Iterate properly over array elements
-              for url in $(echo "$metadata" | yq -r ".$field[]" || true); do
-                if [[ -z "$url" ]]; then  # Skip empty values inside arrays
-                  continue
+            # Check if the field is an array
+            local field_type
+            field_type=$(echo "$metadata" | yq -r ".$field | type")
+
+            if [[ "$field_type" == "!!seq" ]]; then
+              # Check if the array is completely empty (length == 0)
+              local array_length
+              array_length=$(echo "$metadata" | yq -r ".$field | length")
+
+              if [[ "$array_length" -eq 0 ]]; then
+                echo "DEBUG: '$field' is an empty array, skipping validation."
+                if [[ "$required" == "required" ]]; then
+                  echo "::error file=$metadata_file::'$field' is required but missing"
+                  ((errors++))
+                fi
+                return 0
+              fi
+
+              # Extract array values while removing empty strings and nulls
+              urls=$(echo "$metadata" | yq -r ".$field | map(select(. != null and . != \"\")) | .[]?" || true)
+
+              # DEBUGGING: Print extracted values before validation
+              echo "DEBUG: Extracted URLs for '$field':"
+              echo "$urls" | cat -A  # Helps visualize hidden characters
+
+              # Iterate over non-empty elements in the array
+              echo "$urls" | while IFS= read -r url; do
+                if [[ -z "$url" ]]; then
+                  continue  # Explicitly skip any remaining empty values
                 fi
+                echo "DEBUG: Validating URL: '$url'"
                 if [[ ! "$url" =~ ^https?:\/\/[a-zA-Z0-9.-]+(\.[a-zA-Z]{2,})+(:[0-9]{1,5})?(\/.*)?$ ]]; then
-                  echo "::error file=$metadata_file::'$field' contains an invalid URL: $url"
-                  ((errors++))
+                   echo "::error file=$metadata_file::'$field' contains an invalid URL: $url"
+                   ((errors++))
                 fi
               done
-            else
-              if [[ ! "$value" =~ ^https?:\/\/[a-zA-Z0-9.-]+(\.[a-zA-Z]{2,})+(:[0-9]{1,5})?(\/.*)?$ ]]; then
-                echo "::error file=$metadata_file::'$field' is not a valid URL"
-                ((errors++))
-              fi
             fi
           }