test

Author: Ang-dot

.github/workflows/validate-new-plugin-metadata.yml

@@ -80,36 +80,56 @@ jobs:
           # Function to validate a URL field (supports single values and arrays)
           check_valid_url() {
             local field="$1"
-            local required="${2:-optional}"  # Default to "optional" if no second parameter is provided
-            local value=$(echo "$metadata" | yq ".$field" || true)
+            local field_type="${2:-single_value}"  # Default to "single_value" if no second parameter is provided
+            local required="${3:-optional}"  # Default to "optional" if no third parameter is provided
 
-            # If field is missing or empty
-            if [[ -z "$value" ]]; then
-              if [[ "$required" == "required" ]]; then
-                echo "::error file=$metadata_file::'$field' is required but missing"
-                ((errors++))
+            if [[ "$field_type" == "single_value" ]]; then
+              local value=$(echo "$metadata" | yq ".$field" || true)
+
+              # If field is missing or empty
+              if [[ -z "$value" ]]; then
+                if [[ "$required" == "required" ]]; then
+                  echo "::error file=$metadata_file::'$field' is required but missing"
+                  ((errors++))
+                fi
+                return 0  # Skip validation if it's optional and missing
               fi
-              return 0  # Skip validation if it's optional and missing
-            fi
+            else
+              # Extract array from YAML
+              local raw_array
+              raw_array=$(echo "$metadata" | yq -r ".$field | .[]" || echo "")
+
+              mapfile -t array <<< "$raw_array"
 
-            # Handle arrays of URLs (e.g., screenshots)
-            # Check if the field is an array using yq length check
-            is_array=$(echo "$metadata" | yq -r ".${field} | length")
-            
-            if [[ "$is_array" =~ ^[0-9]+$ && "$is_array" -gt 0 ]]; then
-              # Iterate properly over array elements
-              for url in $(echo "$metadata" | yq -r ".$field[]" || true); do
-                if [[ -z "$url" ]]; then  # Skip empty values inside arrays
-                  continue
+              # Count total entries, including empty ones
+              local all_entries=$(echo "$metadata" | yq -r ".$field | length" || echo "0")
+
+              # Count empty entries correctly
+              local empty_entries=0
+              for entry in "${array[@]}"; do
+                if [[ -z "$entry" ]]; then
+                  ((empty_entries++))
                 fi
-                if [[ ! "$url" =~ ^https?:\/\/[a-zA-Z0-9.-]+(\.[a-zA-Z]{2,})+(:[0-9]{1,5})?(\/.*)?$ ]]; then
-                  echo "::error file=$metadata_file::'$field' contains an invalid URL: $url"
-                  ((errors++))
+              done
+
+              echo "Total array length (including empty): $all_entries"
+              echo "Empty string entries: $empty_entries"
+
+              local non_empty_entries=0
+
+              for url in "${array[@]}"; do
+                if [[ -n "$url" ]]; then
+                  if [[ "$url" =~ ^(https?:\/\/[a-zA-Z0-9.-]+(\.[a-zA-Z]{2,})+(:[0-9]{1,5})?(\/.*)?)$ ]]; then
+                    ((non_empty_entries++))
+                  else
+                    echo "::error file=$metadata_file::'$field' contains an invalid URL: $url"
+                    ((errors++))
+                  fi
                 fi
               done
-            else
-              if [[ ! "$value" =~ ^https?:\/\/[a-zA-Z0-9.-]+(\.[a-zA-Z]{2,})+(:[0-9]{1,5})?(\/.*)?$ ]]; then
-                echo "::error file=$metadata_file::'$field' is not a valid URL"
+
+              if [[ "$required" == "required" && "$non_empty_entries" -eq 0 ]]; then
+                echo "::error file=$metadata_file::'$field' is required but missing"
                 ((errors++))
               fi
             fi
@@ -128,7 +148,7 @@ jobs:
           check_valid_url "demo_video_url"
           check_valid_url "documentation_url"
           check_valid_url "changelog_url"
-          check_valid_url "screenshots"
+          check_valid_url "screenshots" "array"
 
           # Validate date format (YYYY-MM)
           release_date=$(echo "$metadata" | yq '.release_date')