test

Author: Ang-dot

.github/workflows/validate-new-plugin-metadata.yml

@@ -65,6 +65,7 @@ jobs:
           echo "::group::Validating $metadata_file"
 
           metadata=$(yq '.' "$metadata_file")
+          echo "Metadata: $metadata"
           errors=0
 
           # Function to check if a required field is missing
@@ -94,19 +95,25 @@ jobs:
 
             # Handle arrays of URLs (e.g., screenshots)
             # Check if the field is an array using yq length check
-            is_array=$(echo "$metadata" | yq -r ".${field} | length")
-            
-            if [[ "$is_array" =~ ^[0-9]+$ && "$is_array" -gt 0 ]]; then
-              # Iterate properly over array elements
-              for url in $(echo "$metadata" | yq -r ".$field[]" || true); do
-                if [[ -z "$url" ]]; then  # Skip empty values inside arrays
+            local field_type=$(echo "$metadata" | yq -r ".${field} | type")
+            local non_empty_value=0
+
+            if [[ "$field_type" == "!!seq" ]]; then
+              for url in $(echo "$metadata" | yq ".$field | .[]"); do
+                if [[ -z "$url" ]]; then
                   continue
                 fi
                 if [[ ! "$url" =~ ^https?:\/\/[a-zA-Z0-9.-]+(\.[a-zA-Z]{2,})+(:[0-9]{1,5})?(\/.*)?$ ]]; then
                   echo "::error file=$metadata_file::'$field' contains an invalid URL: $url"
                   ((errors++))
+                else
+                  ((non_empty_value++))
                 fi
               done
+              if [[ $non_empty_value -eq 0 && "$required" == "required" ]]; then
+                echo "::error file=$metadata_file::'$field' is required but missing"
+                ((errors++))
+              fi  
             else
               if [[ ! "$value" =~ ^https?:\/\/[a-zA-Z0-9.-]+(\.[a-zA-Z]{2,})+(:[0-9]{1,5})?(\/.*)?$ ]]; then
                 echo "::error file=$metadata_file::'$field' is not a valid URL"
@@ -122,18 +129,19 @@ jobs:
           check_required_field "detailed_description"
 
           # Validate URLs (optional fields but must be valid if provided, add "required" as second parameter to make them required, ie: check_valid_url "community_url" "required")
-          check_valid_url "community_url"
           check_valid_url "logo_url"
           check_valid_url "plugin_logo_url"
           check_valid_url "demo_video_url"
           check_valid_url "documentation_url"
           check_valid_url "changelog_url"
+          check_valid_url "community_url"
           check_valid_url "screenshots"
 
+          echo "Metadata: $metadata"
           # Validate date format (YYYY-MM)
           release_date=$(echo "$metadata" | yq '.release_date')
           if [[ -z "$release_date" ]]; then
-            echo "::error file=$metadata_file::'$release_date' is required but missing"
+            echo "::error file=$metadata_file::'release_date' is required but missing"
             ((errors++))
           else
             if [[ ! "$release_date" =~ ^202[0-9]{1}-[0-9]{2}$ ]]; then
@@ -143,9 +151,10 @@ jobs:
           fi
 
           # Validate X account handle format (@username)
+          echo "The X account handle is: $(echo "$metadata" | yq '.x_account_handle')"
           x_account_handle=$(echo "$metadata" | yq '.x_account_handle')
           if [[ -z "$x_account_handle" ]]; then
-            echo "::error file=$metadata_file::'$x_account_handle' is required but missing"
+            echo "::error file=$metadata_file::'x_account_handle' is required but missing"
             ((errors++))
           else
             if [[ -n "$x_account_handle" && ! "$x_account_handle" =~ ^@[a-zA-Z0-9_]{1,15}$ ]]; then
@@ -155,9 +164,10 @@ jobs:
           fi
 
           # Validate support contact (must be a valid URL or email)
+          echo "The support contact is: $(echo "$metadata" | yq '.support_contact')"
           support_contact=$(echo "$metadata" | yq '.support_contact')
           if [[ -z "$support_contact" ]]; then
-            echo "::error file=$metadata_file::'$support_contact' is required but missing"
+            echo "::error file=$metadata_file::'support_contact' is required but missing"
             ((errors++))
           else
             if [[ ! "$support_contact" =~ ^(https?:\/\/[a-zA-Z0-9.-]+(\.[a-zA-Z]{2,})+(:[0-9]{1,5})?(\/.*)?|[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\.[a-zA-Z]{2,})$ ]]; then