test

Author: Ang-dot

.github/workflows/validate-new-plugin-metadata.yml

@@ -94,24 +94,27 @@ jobs:
 
             # Handle arrays of URLs (e.g., screenshots)
             # Check if the field is an array using yq length check
-            is_array=$(echo "$metadata" | yq -r ".${field} | length")
-            
-            if [[ "$is_array" =~ ^[0-9]+$ && "$is_array" -gt 0 ]]; then
-              # Iterate properly over array elements
-              for url in $(echo "$metadata" | yq -r ".$field[]" || true); do
-                if [[ -z "$url" ]]; then  # Skip empty values inside arrays
-                  continue
-                fi
+            local field_type
+            field_type=$(echo "$metadata" | yq -r ".${field} | type")
+
+            if [[ "$field_type" == "!!seq" ]]; then
+              # Extract array values and remove empty strings
+              urls=$(echo "$metadata" | yq -r ".$field | map(select(. != null and . != \"\")) | .[]?" || true)
+
+              # If the array is empty or contains only empty strings, trigger an error for required fields
+              if [[ -z "$urls" && "$required" == "required" ]]; then
+                echo "::error file=$metadata_file::'$field' is required but missing"
+                ((errors++))
+                return 0
+              fi
+          
+              # Properly iterate over the non-empty elements in the array
+              echo "$urls" | while IFS= read -r url; do
                 if [[ ! "$url" =~ ^https?:\/\/[a-zA-Z0-9.-]+(\.[a-zA-Z]{2,})+(:[0-9]{1,5})?(\/.*)?$ ]]; then
                   echo "::error file=$metadata_file::'$field' contains an invalid URL: $url"
                   ((errors++))
                 fi
               done
-            else
-              if [[ ! "$value" =~ ^https?:\/\/[a-zA-Z0-9.-]+(\.[a-zA-Z]{2,})+(:[0-9]{1,5})?(\/.*)?$ ]]; then
-                echo "::error file=$metadata_file::'$field' is not a valid URL"
-                ((errors++))
-              fi
             fi
           }