Skip to content

Commit e396932

Browse files
authored
Merge pull request #191 from game-node-app/dev
fixed gameFilters for GET requests in find-collection-entries.dto
2 parents 1afe02d + 77446bc commit e396932

File tree

2 files changed

+19
-8
lines changed

2 files changed

+19
-8
lines changed

server_swagger.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

src/collections/collections-entries/dto/find-collection-entries.dto.ts

Lines changed: 18 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,22 @@ export class FindCollectionEntriesDto extends OmitType(
3333
@IsString()
3434
status?: CollectionEntryStatus;
3535
@IsOptional()
36-
gameFilters?: FindCollectionEntriesGameFilterDto = {
37-
category: [
38-
EGameCategory.Main,
39-
EGameCategory.Remaster,
40-
EGameCategory.Remake,
41-
],
42-
};
36+
// Forces orderBy's Transform to run
37+
@Expose({ name: "gameFilters" })
38+
// This extra logic makes the orderBy work for GET request parameters
39+
@Transform(({ obj }) => {
40+
const rawQueryString = qs.stringify(obj);
41+
const parsed = qs.parse(rawQueryString);
42+
43+
return (
44+
parsed.gameFilters ?? {
45+
category: [
46+
EGameCategory.Main,
47+
EGameCategory.Remaster,
48+
EGameCategory.Remake,
49+
],
50+
}
51+
);
52+
})
53+
gameFilters?: FindCollectionEntriesGameFilterDto;
4354
}

0 commit comments

Comments
 (0)