Merge pull request #18 from gameeapp/add_to_list_method

feat: methods added to unique collection: toList
feat: optimized getFirst/Last methods

Author: TomPavelec

src/Collection/UniqueObjectCollection.php

@@ -218,15 +218,15 @@ public function exists(string|int $key): bool
 
 
     /**
-     * Starts with zero (0)
-     *
      * @return IdentifiableObject
      *
      * @throws ItemDoesNotExistException
      */
     public function getFirst()
     {
-        return $this->getByIndex(1);
+        return $this->get(
+            \array_key_first($this->data) ?? throw new ItemDoesNotExistException('first', 'index'),
+        );
     }
 
 
@@ -237,8 +237,8 @@ public function getFirst()
      */
     public function getLast()
     {
-        return $this->getByIndex(
-            \count($this->data),
+        return $this->get(
+            \array_key_last($this->data) ?? throw new ItemDoesNotExistException('last', 'index'),
         );
     }
 
@@ -336,12 +336,24 @@ public function contains(object $item): bool
     }
 
 
-    public function jsonSerialize(): array
+    /**
+     * @return array<int, IdentifiableObject>
+     */
+    public function toList(): array
     {
         return \array_values($this->getItems());
     }
 
 
+    /**
+     * @return array<int, IdentifiableObject>
+     */
+    public function jsonSerialize(): array
+    {
+        return $this->toList();
+    }
+
+
     /**
      * @param IdentifiableObject $item
      */
@@ -351,6 +363,9 @@ protected function getIdentifier(object $item): string|int
     }
 
 
+    /**
+     * @return array<int|string, IdentifiableObject>
+     */
     protected function getItems(): array
     {
         return $this->data;

tests/unit/Collection/UniqueObjectCollectionTest.php

@@ -592,6 +592,42 @@ public function testContains(): void
     }
 
 
+    public function testToList(): void
+    {
+        $list = [
+            new JsonSerializableClass(3),
+            new JsonSerializableClass(5),
+            new JsonSerializableClass(7),
+        ];
+
+        $collection = new UniqueObjectCollection(
+            $list,
+        );
+
+        $listFromCollection = $collection->toList();
+
+        Assert::same(
+            count($listFromCollection),
+            count($list),
+        );
+
+        Assert::same(
+            array_keys($listFromCollection),
+            array_keys($list),
+        );
+
+        Assert::same(
+            $listFromCollection[0],
+            $list[0],
+        );
+
+        Assert::same(
+            $listFromCollection[1],
+            $list[1],
+        );
+    }
+
+
     public function testJsonSerialize(): void
     {
         $collection = new UniqueObjectCollection(