Skip to content

feat: re resource naming #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2025
Merged

feat: re resource naming #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f2f690
feat!: update resouce naming option
yicr Mar 6, 2025
8d70578
chore: workflow node version set 22.x
yicr Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/upgrade-main.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .projenrc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const project = new awscdk.AwsCdkConstructLibrary({
releaseToNpm: true,
npmAccess: javascript.NpmAccess.PUBLIC,
minNodeVersion: '18.0.0',
workflowNodeVersion: '22.5.x',
workflowNodeVersion: '22.x',
depsUpgradeOptions: {
workflowOptions: {
labels: ['auto-approve', 'auto-merge'],
Expand Down
11 changes: 8 additions & 3 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
import { ResourceAutoNaming, ResourceDefaultNaming, ResourceNaming, ResourceNamingType } from '@gammarers/aws-resource-naming';
import {
ResourceAutoNaming,
ResourceDefaultNaming,
ResourceNaming,
ResourceNamingType as CodeConnectionsHostCustomResourceResourceNamingType,
} from '@gammarers/aws-resource-naming';
import * as cdk from 'aws-cdk-lib';
import * as iam from 'aws-cdk-lib/aws-iam';
import * as cr from 'aws-cdk-lib/custom-resources';
import { Construct } from 'constructs';

export { ResourceAutoNaming, ResourceDefaultNaming, ResourceNamingType };
export { CodeConnectionsHostCustomResourceResourceNamingType };

// Bitbucket | GitHub | GitHubEnterpriseServer | GitLab | GitLabSelfManaged
export enum CodeConnectionsHostProviderType {
Expand Down Expand Up @@ -64,7 +69,7 @@ export enum ResponseField {
//}

export interface CustomNaming {
readonly type: ResourceNamingType.CUSTOM;
readonly type: CodeConnectionsHostCustomResourceResourceNamingType.CUSTOM;
// readonly names: Names; // CUSTOM の場合に必須
readonly functionName: string; // フラット化
readonly functionRoleName: string; // フラット化
Expand Down