remove xtd::optional for operator 'controls()[name]'

Author: gammasoft71

examples/xtd.forms.examples/others/control_with_name_operator/src/control_with_name_operator.cpp

@@ -8,17 +8,17 @@ namespace control_with_name_operator_example {
       button1.name("button1");
       label1.name("label1");
 
-      controls()["button1"].value().get().location({10, 10});
-      controls()["button1"].value().get().text("Click me");
-      as<button>(controls()["button1"].value().get()).auto_repeat(true);
-      controls()["button1"].value().get().click += delegate_ {
+      controls()["button1"].get().location({10, 10});
+      controls()["button1"].get().text("Click me");
+      as<button>(controls()["button1"].get()).auto_repeat(true);
+      controls()["button1"].get().click += delegate_ {
         static int count = 0;
-        controls()["label1"].value().get().text(string::format("button clicked {} times", ++count));
+        controls()["label1"].get().text(string::format("button clicked {} times", ++count));
       };
 
-      controls()["label1"].value().get().auto_size(true);
-      controls()["label1"].value().get().location({10, 50});
-      controls()["label1"].value().get().text("button clicked 0 times");
+      controls()["label1"].get().auto_size(true);
+      controls()["label1"].get().location({10, 50});
+      controls()["label1"].get().text("button clicked 0 times");
     }
 
   private:

examples/xtd.forms.examples/others/emplace/src/emplace.cpp

@@ -4,10 +4,10 @@ auto main() -> int {
   auto button1_clicked = 0, button2_clicked = 0;
   auto form1 = form::create("Emplace example");
   form1.controls().emplace_front<button>("Button 1", point{50, 50}).click += delegate_ {
-    form1.controls()["label1"].value().get().text(string::format("Button 1 clicked {} times", ++button1_clicked));
+    form1.controls()["label1"].get().text(string::format("Button 1 clicked {} times", ++button1_clicked));
   };
   form1.controls().emplace_at<button>(1, "Button 2", point {50, 100}, drawing::size {200, 75}).auto_repeat(true).click += delegate_ {
-    form1.controls()["label2"].value().get().text(string::format("Button 2 clicked {} times", ++button2_clicked));
+    form1.controls()["label2"].get().text(string::format("Button 2 clicked {} times", ++button2_clicked));
   };
   form1.controls().emplace_at<label>(2, "Button 1 clicked 0 times", point {50, 200}, drawing::size {200, 23}, "label1");
   form1.controls().emplace_back<label>("Button 2 clicked 0 times", point {50, 230}, drawing::size {200, 23}, "label2");

src/xtd.forms/include/xtd/forms/control.hpp

@@ -186,12 +186,12 @@ namespace xtd {
         /// @param name The name of the xtd::forms::control to get from the list.
         /// @return The first xtd::forms::control in the list with the given Name. This item returns optional with no value if no xtd::forms::control with the given name can be found.
         /// @remarks The operator [] property is case-sensitive when searching for names. That is, if two controls exist with the names "Lname" and "lname", operator [] property will find only the xtd::forms::control with the xtd::forms::control::name() that you specify, not both.
-        std::optional<value_type> operator [](const xtd::string& name) const;
+        value_type operator [](const xtd::string& name) const;
         /// @brief Gets the first xtd::forms::control::control_collection in the list with the specified name.
         /// @param name The name of the xtd::forms::control to get from the list.
         /// @return The first xtd::forms::control in the list with the given Name. This item returns optional with no value if no xtd::forms::control with the given name can be found.
         /// @remarks The operator [] property is case-sensitive when searching for names. That is, if two controls exist with the names "Lname" and "lname", operator [] property will find only the xtd::forms::control with the xtd::forms::control::name() that you specify, not both.
-        std::optional<value_type> operator [](const xtd::string& name);
+        value_type operator [](const xtd::string& name);
         /// @}
 
         /// @name Public Methods

src/xtd.forms/src/xtd/forms/control.cpp

@@ -105,13 +105,13 @@ control::control_collection& control::control_collection::operator = (const cont
   return *this;
 }
 
-std::optional<control::control_collection::value_type> control::control_collection::operator [](const string& name) const {
+control::control_collection::value_type control::control_collection::operator [](const string& name) const {
   for (auto item : *this)
     if (item.get().name() == name) return item;
   return {};
 }
 
-std::optional<control::control_collection::value_type> control::control_collection::operator [](const string& name) {
+control::control_collection::value_type control::control_collection::operator [](const string& name) {
   for (auto item : *this)
     if (item.get().name() == name) return item;
   return std::nullopt;