Trying to resolve the failing tests

Author: Leo

PackageInfo.g

@@ -5,7 +5,7 @@
 SetPackageInfo( rec(
 PackageName := "ModIsom",
 Subtitle := "Computing automorphisms and checking isomorphisms for modular group algebras of finite p-groups",
-Version := "3.0.1",
+Version := "3.0.2",
 Date := "28/12/2024", # dd/mm/yyyy format
 License := "GPL-2.0-or-later",
 

VERSION

@@ -1 +1 @@
-3.0.0
+3.0.2

changes.txt

@@ -1,3 +1,9 @@
+
+Changes in 3.0.2: 
+- corrected a mistake in the function JenningsInfoAllFields
+- slight modification of manual
+
+------------------------------------------
 Changes in version 3.0.1: LAGUNA is now a requiered package. This solves the issue of warnings coming up when ModIsom was loaded without LAGUNA
 
 -----------------------------------------------------------------

doc/modisom.tex

@@ -110,7 +110,7 @@
 
 For more evolved calculations one can use the function
 
-\> MIPBinSplit(p, n, k, start, step, L, [f])
+\> MIPBinSplit(p, n, max, start, step, L, [f])
 
 Given a list $L$ of small group library Id's or a list of groups of order $p^n$ this functions checks
 isomorphism of the associated modular group algebras using canonical forms for the quotients of the
@@ -525,6 +525,8 @@
  cohomology group which equals the number $\sum_{g^G} \log_p(C_G(g)/\Phi(C_G(g))$ where the sum runs over
  all the conjugacy classes of $G$ \cite{HS06}(Section 2.6). 
 
+ The return contains first the Roggenkamp parameter, then the Kuelshammer invariants (starting from $i = 0)$ and then the invariant of Parmenter-Polcino Milies.
+ 
 \> SubgroupsInfo(G) F
 
 Computes the number of conjugacy classes of maximal elementary abelian subgroups of rank 1,2,...

gap/grpalg/detbins.gi

@@ -155,9 +155,6 @@ BindGlobal("JenningsInfoAllFields", function(G)
     r := [];
     for i in [1..Length(s)-1] do
         a := [GroupInfo(s[i]/s[i+1])];
-        if i <= Length(s)-2 then
-            Add(a, GroupInfo(s[i]/s[i+2]));
-        fi;
         Add(r, a);
     od;
     return r;
@@ -704,90 +701,90 @@ BindGlobal("OnlyJenningsInfo", function(G)
 end);
 
 BindGlobal("CenterNormalInfo", function(G, N)
-  local ZI,ZQ;
-  ZI:=Intersection(Center(G), N);
-  ZQ:= Subgroup(G, Union(GeneratorsOfGroup(Center(G)), GeneratorsOfGroup(N)))/N;
+  local ZI, ZQ;
+  ZI := Intersection(Center(G), N);
+  ZQ := Subgroup(G, Union(GeneratorsOfGroup(Center(G)), GeneratorsOfGroup(N)))/N;
   return [ AbelianInvariants(ZI), AbelianInvariants(ZQ)];
 end);
 
 
 #L is normal, N contains G'
-BindGlobal("LNInfo", function(G,L,N)
-  local LN,Q1,Q2;
-  LN:= Subgroup(G, Union(GeneratorsOfGroup(N), GeneratorsOfGroup(L)));
-  Q1:=G/LN;
-  Q2:=LN/N;
+BindGlobal("LNInfo", function(G, L, N)
+  local LN, Q1, Q2;
+  LN := Subgroup(G, Union(GeneratorsOfGroup(N), GeneratorsOfGroup(L)));
+  Q1 := G/LN;
+  Q2 := LN/N;
   return [AbelianInvariants(Q1), AbelianInvariants(Q2)];
 end);
 
 
 # The next three functions are the operations preserving canonicity described in Lemma 3.6.
-BindGlobal("OmegaModuloN", function(G,N,p,t)
-  local f, Q,R;
+BindGlobal("OmegaModuloN", function(G, N, p, t)
+  local f, Q, R;
   if Size(N)=Size(G) then return G; else
-  f:= NaturalHomomorphismByNormalSubgroup( G, N );
-  Q:=Image(f);
-  R:=Omega(Q,p, t);
-  return PreImage(f,R);
+  f := NaturalHomomorphismByNormalSubgroup( G, N );
+  Q := Image(f);
+  R := Omega(Q, p, t);
+  return PreImage(f, R);
   fi;
 end);
 
-BindGlobal("AgemoLModuloN", function(G,L,N,p,t)
+BindGlobal("AgemoLModuloN", function(G, L, N, p, t)
   local AgemoL;
-  AgemoL:=Agemo(L, p,t);
+  AgemoL := Agemo(L, p, t);
   return Subgroup(G, Union(GeneratorsOfGroup(AgemoL), GeneratorsOfGroup(N)));
 end);
 
 
 BindGlobal("OmegaCenterN", function(G,N,p,t)
     local OmegaCenter;
-    OmegaCenter:=Omega(Center(G), p,t);
+    OmegaCenter := Omega(Center(G), p, t);
     return Subgroup(G, Union(GeneratorsOfGroup(OmegaCenter), GeneratorsOfGroup(N)));
 end);
 
 #N is a subgroup containing G'. Then the following function computes the subgroups obtained using the previous operations.
 #(Observe that if L=G, t doesn't really matter since the output for different values of t can be obtained iterating of the operation).
-BindGlobal("SuccessorsN", function(G,L,N,p)
-  local S1,S2,S3, SizeN, successorsN;
-  successorsN:=[];
-  SizeN:=Size(N);
-  S1:=OmegaModuloN(G,N,p,1);
-  if Size(S1)<>SizeN then Add(successorsN, S1); fi;
-  S2:=AgemoLModuloN(G,L,N,p,1);
-  if Size(S2)<>SizeN then Add(successorsN, S2); fi;
-  S3:=OmegaCenterN(G,N,p,1);
-  if Size(S3)<>SizeN then Add(successorsN, S3); fi;
+BindGlobal("SuccessorsN", function(G, L, N, p)
+  local S1, S2, S3, SizeN, successorsN;
+  successorsN := [ ];
+  SizeN := Size(N);
+  S1 := OmegaModuloN(G, N, p, 1);
+  if Size(S1) <> SizeN then Add(successorsN, S1); fi;
+  S2 := AgemoLModuloN(G, L, N, p, 1);
+  if Size(S2) <> SizeN then Add(successorsN, S2); fi;
+  S3 := OmegaCenterN(G, N, p, 1);
+  if Size(S3) <> SizeN then Add(successorsN, S3); fi;
   return successorsN;
 end);
 
 #!
 BindGlobal("CanonicalNormalSubgroups", function(G)
-  local normalSubgroups, normalSubgroupsLeveli,normalSubgroupsLevelip1,e,Gprime,Ab, SN,N,p, normalSubgroups0, i;
-  Gprime:=DerivedSubgroup(G);
-  normalSubgroups:=[Gprime];
-  p:=Factors(Order(G))[1];
-  Ab:=G/Gprime;
-  e:=3*Log(Exponent(Ab),p);  #Probably using this e as a bound makes no sense.
-  normalSubgroupsLeveli:=normalSubgroups;
+  local normalSubgroups, normalSubgroupsLeveli, normalSubgroupsLevelip1, e, Gprime, Ab, SN, N, p, normalSubgroups0, i;
+  Gprime := DerivedSubgroup(G);
+  normalSubgroups := [Gprime];
+  p := Factors(Order(G))[1];
+  Ab := G/Gprime;
+  e := 3*Log(Exponent(Ab), p);  #Probably using this e as a bound makes no sense.
+  normalSubgroupsLeveli := normalSubgroups;
   for i in [1..e] do
-    normalSubgroupsLevelip1:=[];
+    normalSubgroupsLevelip1 := [ ];
     for N in normalSubgroupsLeveli do
-        SN:=SuccessorsN(G,G,N,p);
-        normalSubgroupsLevelip1:=Concatenation(normalSubgroupsLevelip1, SN);
+        SN := SuccessorsN(G, G, N, p);
+        normalSubgroupsLevelip1 := Concatenation(normalSubgroupsLevelip1, SN);
     od;
-    normalSubgroupsLeveli:=normalSubgroupsLevelip1;
-    normalSubgroups:=Concatenation(normalSubgroups, normalSubgroupsLevelip1);
+    normalSubgroupsLeveli := normalSubgroupsLevelip1;
+    normalSubgroups := Concatenation(normalSubgroups, normalSubgroupsLevelip1);
   od;
   #Some subgroups are missing, for examples the last ones in Remark 3.6 (3), because when L is not G the value of t matters.
-  normalSubgroups0:=normalSubgroups;
+  normalSubgroups0 := normalSubgroups;
   return normalSubgroups;
 end);
 
 #The next function collects the data arising from the Jenning series of the (major part of) canonical normal subgroups.
 BindGlobal("NormalSubgroupsInfo", function(G)
   local normalSubgroups,Gprime;
-  Gprime:=DerivedSubgroup(G);
-  return List(CanonicalNormalSubgroups(G), x->[OnlyJenningsInfo(x), CenterNormalInfo(G,x), LNInfo(G,x,Gprime)]);
+  Gprime := DerivedSubgroup(G);
+  return List(CanonicalNormalSubgroups(G), x -> [OnlyJenningsInfo(x), CenterNormalInfo(G, x), LNInfo(G, x, Gprime)]);
 end);
 #####################
 

tst/manexamples.tst

@@ -96,9 +96,9 @@ gap> bins := BinsByGT(2,6);
 [ [ 156, 158, 160 ], [ 155, 157 ], [ 173, 176 ], [ 179, 180 ] ]
 
 #####################################################################
-gap> MIPSplitGroupsByAlgebras(2,6,bins[1]).bins;
+gap> MIPSplitGroupsByAlgebras(2,6,[156,158,160]).bins;
 [  ]
-gap> MIPSplitGroupsByAlgebras(2,6,bins[1]).splits;
+gap> MIPSplitGroupsByAlgebras(2,6,[156,158,160]).splits;
 [ [ 7, [ 156, 158, 160 ] ] ]
 
 #####################################################################