Skip to content

Commit bc44172

Browse files
authored
Fix yet another issue in the char 0 matrix code (#6144)
1 parent 7a11517 commit bc44172

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

lib/grpramat.gi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ function( G )
333333
return fail;
334334
fi;
335335
fi;
336-
return Hnice(x * e);
336+
return ImageElm(Hnice, x * e);
337337
end,
338338
function(y)
339339
return inv(y);

tst/testbugfix/2025-10-02-char0-matrixgroups.tst

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,3 +29,15 @@ gap> Centralizer(G,[[0, 0, 0, 0], [0, 1/3, 1/3, 1/3], [0, 1/3, 1/3, 1/3], [0, 1/
2929
<matrix group with 4 generators>
3030
gap> Size(last);
3131
24
32+
33+
#
34+
# Another problem related to this: Using `Image` to apply an intermediate nice
35+
# monomorphism for a FFE matrix group would raise an error if testing inputs
36+
# outside its domain; changing this to use ImageElm instead produces `fail`,
37+
# which is what we need for e.g. membership tests.
38+
# See <https://github.com/gap-system/gap/issues/6142>
39+
#
40+
gap> G:=Group([ [ [ 1, 0, 0, 0 ], [ 0, 0, 1, 0 ], [ 0, 0, 0, 1 ], [ 0, 1, 0, 0 ] ], [ [ 0, 1/2*E(5)+1/2*E(5)^4, 1/2, 1/2*E(5)^2+1/2*E(5)^3 ], [ 1/2*E(5)+1/2*E(5)^4, -1/2*E(5)^2-1/2*E(5)^3, -1/2, 0 ], [ 1/2, -1/2, -1/2, -1/2 ], [ 1/2*E(5)^2+1/2*E(5)^3, 0, -1/2, -1/2*E(5)-1/2*E(5)^4 ] ] ]);;
41+
gap> g:=[ [ 1, 0, 0, 0 ], [ 0, -1/2, 1/2*E(5)^2+1/2*E(5)^3, -1/2*E(5)-1/2*E(5)^4 ], [ 0, 1/2*E(5)^2+1/2*E(5)^3, 1/2*E(5)+1/2*E(5)^4, 1/2 ], [ 0, -1/2*E(5)-1/2*E(5)^4, 1/2, 1/2*E(5)^2+1/2*E(5)^3 ] ];;
42+
gap> g in G;
43+
false

0 commit comments

Comments
 (0)