Skip to content

Commit ca722b5

Browse files
committed
Add a bunch of new filters for FFE and cylotomic matrices
1 parent 99643f4 commit ca722b5

File tree

2 files changed

+30
-4
lines changed

2 files changed

+30
-4
lines changed

lib/matobj1.gd

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,36 @@ DeclareCategory( "IsMatrixObj", IsMatrixOrMatrixObj );
263263
DeclareCategory( "IsRowListMatrix", IsMatrixObj );
264264

265265

266+
267+
#############################################################################
268+
##
269+
# Two filters to speed up some methods:
270+
DeclareFilter( "IsIntVector" ); # TODO: replace this legacy filter from matobjplist.gi with something better
271+
DeclareFilter( "IsFFEVector" );
272+
273+
DeclareCategory( "IsFFEVectorObj", IsVectorObj );
274+
DeclareCategory( "IsCyclotomicVectorObj", IsVectorObj );
275+
276+
DeclareCategory( "IsFFEMatrixOrMatrixObj", IsMatrixOrMatrixObj );
277+
# DeclareSynonym( "IsFFEMatrix", IsFFEMatrixOrMatrixObj and IsMatrix );
278+
# DeclareSynonym( "IsFFEMatrixObj", IsFFEMatrixOrMatrixObj and IsMatrixObj );
279+
# or maybe
280+
# DeclareProperty( "IsFFEMatrix", IsMatrix );
281+
# DeclareProperty( "IsFFEMatrixObj", IsMatrixObj );
282+
283+
DeclareCategory( "IsCyclotomicMatrixOrMatrixObj", IsMatrixOrMatrixObj );
284+
# DeclareSynonym( "IsCyclotomicMatrix", IsCyclotomicMatrixOrMatrixObj and IsMatrix );
285+
# DeclareSynonym( "IsCyclotomicMatrixObj", IsCyclotomicMatrixOrMatrixObj and IsMatrixObj );
286+
# or maybe have them be properties with methods so users are not confused ?!?
287+
# DeclareProperty( "IsCyclotomicMatrix", IsMatrix );
288+
# DeclareProperty( "IsCyclotomicMatrixObj", IsMatrixObj );
289+
290+
291+
InstallTrueMethod( IsFFEMatrixOrMatrixObj, IsFFECollColl and IsMatrix );
292+
InstallTrueMethod( IsCyclotomicMatrixOrMatrixObj, IsCyclotomicCollColl and IsMatrix );
293+
294+
295+
266296
#############################################################################
267297
##
268298
#A BaseDomain( <vector> )

lib/matobjplist.gd

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,3 @@ BindGlobal( "ROWSPOS", 4 );
122122
#BindGlobal( "BDPOS", 1 ); # see above
123123
BindGlobal( "ELSPOS", 2 );
124124

125-
# Two filters to speed up some methods:
126-
DeclareFilter( "IsIntVector" );
127-
DeclareFilter( "IsFFEVector" );
128-

0 commit comments

Comments
 (0)