-
Notifications
You must be signed in to change notification settings - Fork 70
Engineering Practices
Song Zheng edited this page Apr 15, 2020
·
25 revisions
Best practice to follow
- when you run
npm run test
, there's a column calledUncovered Lines
that tells you which lines are not tested
- All of your commits must be tagged with an issue number. If your commit fixes / resolves an issue, make sure it says in your commit. For example:
git commit -m 'close #42 - adds username validation for length'
- You must break down an issue into multiple PRs if the issue is complex.
git commit -m 'update #42 - creates new service function to create login session'
- Do not lower 100% Code Coverage
- Do not use
a
anchor tags unless it is to a different domain. Must useLink
component for client side rendering. - Storybook - If you build a reusable component, please create a component with all the possible states in your component so other devs know how to use that component.