Skip to content

Engineering Practices

Song Zheng edited this page Apr 14, 2020 · 25 revisions

Intro

Best practice to follow

  • when you run npm run test, there's a column called Uncovered Lines that tells you which lines are not tested

Development

  • All of your commits must be tagged with an issue number. If your commit fixes / resolves an issue, make sure it says in your commit. For example:
    • git commit -m 'close #42 - adds username validation for length'
  • You must break down an issue into multiple PRs if the issue is complex.
    • git commit -m 'update #42 - creates new service function to create login session'
  • Do not lower 100% Code Coverage
  • Do not use a anchor tags. Must use Link component for client side rendering.

React

Clone this wiki locally