-
Notifications
You must be signed in to change notification settings - Fork 70
Onboarding
- You first step at any new company you join as an engineer is to improve documentation. Starting from here, try to read through the relevant documentation and setup your codebase. When you get stuck, ask for help and then edit and improve the document you are reading to make it easier for the next engineer that joins.
-
PRO TIP - You should always be improving documentation, no matter who wrote the original document, no matter how new you are, no matter how pro you've become.
-
- Made a contribution? Let all contributors bot know
- Setting up the codebase: Follow this beautifully written development setup guide.
-
Review Pull Requests - Always help your teammates out by reviewing pull requests
- Keep our codebase updated and protected by updating libraries via dependabot
- Attend weekly sprint meetings - If a time is inconvenient for you, feel free to propose alternatives!
- Please continue reviewing submissions, especially JS5 and JS6! All js6 submissions can only be reviewed by the engineering team.
- Before starting a big feature or a big change, please write a design doc to document why the change is needed and how you plan to execute the change. Create an issue and label it
design doc
. List of previous design docs created thus far- Read about Design Docs at Google
- Common headers you may want to consider when writing your design docs:
Problem
,Architecture Changes
,Subtasks
,Research
.
Like reading and updating documentation, reviewing pull requests is something you should do from the beginning of your engineering career to the end of your engineering career. When you first join a team, reviewing your teammate's existing pull requests could help you quickly familiarize yourself with what your teammates are working on and gives you a good opportunity to ask questions. Please ask questions when you have questions about the pull request!
c0d3 team requires 2 engineering approvals and passing CI/CD builds before a pull request can be merged in.
Dependabot will send us pull requests every time there are package updates to make sure all of our libraries are up to date. Make sure to stay on top of dependabot pull requests and help us merge in package updates by following this doc
A list of tips for you!
- When writing tests, please write out the actual changes instead of
toMatchSnapShot()
. If we get lazy and usetoMatchSnapShots
all over the place, our tests slow down significantly and when we update a common component like theAppNav
, there would be hundreds of snapshots to update. - Before building a component, please check the storybook (LINK Please) to reuse existing components!
- Accessibility