Skip to content

Use azure disk caching defaults #214

@hebelsan

Description

@hebelsan

What would you like to be added:
The documentation of the caching field is the following:

Specifies the caching requirements. Possible values are: None, ReadOnly, ReadWrite.
The defaulting behavior is: None for Standard storage. ReadOnly for Premium storage.

However we currently always set the caching option to NONE for both dataDisks and osDisks and therefore don't make use of these defaults:

caching := armcompute.CachingTypesNone
if !utils.IsEmptyString(specDataDisk.Caching) {
caching = armcompute.CachingTypes(specDataDisk.Caching)
}

If we change the behaviour in the MCM we can afterwards change the machineclass.yaml template in the provider-extension.
https://github.com/gardener/gardener-extension-provider-azure/blob/6cb84f21b9191f728319e82f66a7804b5818d871/charts/internal/machineclass/templates/machineclass.yaml#L101

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/enhancementEnhancement, improvement, extension

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions