Skip to content

Commit 7c725df

Browse files
committed
Update FAQ regarding node deletion
1 parent aeffe39 commit 7c725df

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

docs/faq.md

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -155,16 +155,14 @@ It can be unpaused again by removing the `Paused` field from the machine-deploym
155155

156156
### How to delete machine object immedietly if I don't have access to it?
157157

158-
If the user doesn't have access to the machine objects (like in case of Gardener clusters) and they would like to replace a node immedietly then they can place the annotation `node.machine.sapcloud.io/trigger-deletion-by-mcm: "true"` on their node. This will start the replacement of the machine with a new node.
159-
160-
On the other hand if the user deletes the node object immedietly then replacement will start only after `MachineHealthTimeout`.
161-
162-
This annotation can also be used if the user wants to expedite the [replacement of unhealthy nodes](#how-does-rate-limiting-replacement-of-machine-work-in-mcm-how-is-it-related-to-meltdown-protection)
158+
If the user deletes the node object, the corresponding machine object is marked for deletion immediately, triggering a replacement. The replacement machine is created to maintain the `desired replicas` specified for the machineDeployment/machineSet.
159+
This can also be used if the user wants to expedite the [replacement of unhealthy nodes](#how-does-rate-limiting-replacement-of-machine-work-in-mcm-how-is-it-related-to-meltdown-protection)
163160

164161
`NOTE`:
165162

166-
- `node.machine.sapcloud.io/trigger-deletion-by-mcm: "false"` annotation is NOT acted upon by MCM , neither does it mean that MCM will not replace this machine.
167-
- this annotation would delete the desired machine but another machine would be created to maintain `desired replicas` specified for the machineDeployment/machineSet. Currently if the user doesn't have access to machineDeployment/machineSet then they cannot remove a machine without replacement.
163+
- The `node.machine.sapcloud.io/trigger-deletion-by-mcm` annotation is no longer supported on node objects. It is however, still supported on machine and machineDeployment objects (used by the CA-MCM cloud provider integration).
164+
- Setting the annotation to `"false"` has never been acted upon by MCM and does not prevent machine replacement.
165+
- Deleting a node will trigger machine deletion and replacement. A new machine will be created to maintain the `desired replicas` specified for the machineDeployment/machineSet. Currently if the user doesn't have access to machineDeployment/machineSet then they cannot remove a machine without replacement.
168166

169167
### How to avoid garbage collection of your node?
170168

pkg/util/provider/machineutils/utils.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ const (
5959
// NotManagedByMCM annotation helps in identifying the nodes which are not handled by MCM
6060
NotManagedByMCM = "node.machine.sapcloud.io/not-managed-by-mcm"
6161

62-
// TriggerDeletionByMCM annotation on the node or machine would trigger the deletion of the corresponding node and machine object in the control cluster
62+
// TriggerDeletionByMCM annotation on the machine would trigger the deletion of the corresponding node and machine object in the control cluster
6363
// This annotation can also be set on the MachineDeployment and contains the machine names for which deletion should be triggered.
6464
// The latter feature is leveraged by the CA-MCM cloud provider.
6565
TriggerDeletionByMCM = "node.machine.sapcloud.io/trigger-deletion-by-mcm"

0 commit comments

Comments
 (0)