Improved logs and comments (#299)

- Moved frequent logs to higher log levels
- Removed unwanted comment message

Author: prashanth26

pkg/controller/deployment.go

@@ -427,9 +427,9 @@ func (dc *controller) getMachineMapForMachineDeployment(d *v1alpha1.MachineDeplo
 // This function is not meant to be invoked concurrently with the same key.
 func (dc *controller) reconcileClusterMachineDeployment(key string) error {
 	startTime := time.Now()
-	glog.V(3).Infof("Started syncing deployment %q (%v)", key, startTime)
+	glog.V(4).Infof("Started syncing machine deployment %q (%v)", key, startTime)
 	defer func() {
-		glog.V(3).Infof("Finished syncing deployment %q (%v)", key, time.Since(startTime))
+		glog.V(4).Infof("Finished syncing machine deployment %q (%v)", key, time.Since(startTime))
 	}()
 
 	_, name, err := cache.SplitMetaNamespaceKey(key)

pkg/controller/machine.go

@@ -109,10 +109,10 @@ func (c *controller) reconcileClusterMachineKey(key string) error {
 }
 
 func (c *controller) reconcileClusterMachine(machine *v1alpha1.Machine) error {
-	glog.V(3).Info("Start Reconciling machine: ", machine.Name)
+	glog.V(4).Info("Start Reconciling machine: ", machine.Name)
 	defer func() {
 		c.enqueueMachineAfter(machine, 10*time.Minute)
-		glog.V(3).Info("Stop Reconciling machine: ", machine.Name)
+		glog.V(4).Info("Stop Reconciling machine: ", machine.Name)
 	}()
 
 	if c.safetyOptions.MachineControllerFrozen && machine.DeletionTimestamp == nil {
@@ -222,7 +222,7 @@ func (c *controller) addNodeToMachine(obj interface{}) {
 		return
 	}
 
-	glog.V(3).Infof("Add machine object backing node %q", machine.Name)
+	glog.V(4).Infof("Add machine object backing node %q", machine.Name)
 	c.enqueueMachine(machine)
 }
 
@@ -506,7 +506,7 @@ func (c *controller) machineDelete(machine *v1alpha1.Machine, driver driver.Driv
 			nodeName := machine.Status.Node
 			drainOptions := NewDrainOptions(
 				c.targetCoreClient,
-				timeOutDuration, // TODO: Need to remove this
+				timeOutDuration,
 				maxEvictRetries,
 				pvDetachTimeOut,
 				nodeName,

pkg/controller/machineset.go

@@ -430,9 +430,9 @@ func (c *controller) manageReplicas(allMachines []*v1alpha1.Machine, machineSet
 // invoked concurrently with the same key.
 func (c *controller) reconcileClusterMachineSet(key string) error {
 	startTime := time.Now()
-	glog.V(3).Infof("Start syncing %q", key)
+	glog.V(4).Infof("Start syncing machine set %q", key)
 	defer func() {
-		glog.V(3).Infof("Finished syncing %q (%v)", key, time.Since(startTime))
+		glog.V(4).Infof("Finished syncing machine set %q (%v)", key, time.Since(startTime))
 	}()
 
 	_, name, err := cache.SplitMetaNamespaceKey(key)