Skip to content

Controller: controller-runtime v0.23 has removed webhook.CustomValidator with adminssions.Validator #155

@kittomic

Description

@kittomic

How to categorize this issue?

/area open-source dev-productivity
/kind enhancement

What would you like to be added:

We should upgrade to the latest versions of our go upstream dependencies:

  • sigs.k8s.io/controller-runtime to v0.23.0
  • k8s.io/* to v0.35.0
  • Refactor api/autoscaling/v1alpha1 to use admissions.Validator

Why is this needed:

controller-runtime v0.23 has removed webhook.CustomValidator in favor of admissions.Validator.

Downstream consumers to the types defined in api/autoscaling/v1alpha1 are blocked from supporting controller-runtime >= v0.23 due to this breaking change.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/dev-productivityDeveloper productivity related (how to improve development)area/open-sourceOpen Source (community, enablement, contributions, conferences, CNCF, etc.) relatedkind/enhancementEnhancement, improvement, extension

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions