linter fixes (#233)

* not using _bucket property anymore
* release notes mock fixed to support quoted version numbers
* calling CName constructor with the commit parameter
* black-reformatted
* disabled useless pyright check for deployment_platform classes
* warn() method is deprecated in logging library
* replaced unneeded short commit
* removed unused imports
* removed more unused imports
* nuked more unused imports
* using cname.cname in download_metadata
* reverted release notes test data update to push it in a separate PR
* disabled meaningless pyright checks
* one more pyright ignore

Author: vivus-ignis

src/gardenlinux/features/cname.py

@@ -13,7 +13,6 @@
 from ..constants import (
     ARCHS,
     GL_BUG_REPORT_URL,
-    GL_COMMIT_SPECIAL_VALUES,
     GL_DISTRIBUTION_NAME,
     GL_HOME_URL,
     GL_RELEASE_ID,

src/gardenlinux/features/metadata_main.py

@@ -6,19 +6,8 @@
 """
 
 import argparse
-import logging
-import re
-from functools import reduce
-from os.path import basename, dirname
-
-from .__main__ import (
-    get_cname_base,
-    get_minimal_feature_set,
-    get_version_and_commit_id_from_files,
-    sort_subset,
-)
+
 from .cname import CName
-from .parser import Parser
 
 _ARGS_ACTION_ALLOWED = [
     "output-release-metadata",

src/gardenlinux/flavors/__main__.py

@@ -6,8 +6,6 @@
 """
 
 import json
-import os
-import sys
 from argparse import ArgumentParser
 from pathlib import Path
 from tempfile import TemporaryDirectory

src/gardenlinux/github/__main__.py

@@ -3,7 +3,11 @@
 from gardenlinux.constants import GARDENLINUX_GITHUB_RELEASE_BUCKET_NAME
 from gardenlinux.logger import LoggerSetup
 
-from .release import create_github_release, upload_to_github_release_page, write_to_release_id_file
+from .release import (
+    create_github_release,
+    upload_to_github_release_page,
+    write_to_release_id_file,
+)
 from .release_notes import create_github_release_notes
 
 LOGGER = LoggerSetup.get_logger("gardenlinux.github", "INFO")
@@ -18,7 +22,7 @@ def main():
     create_parser.add_argument("--repo", default="gardenlinux")
     create_parser.add_argument("--tag", required=True)
     create_parser.add_argument("--commit", required=True)
-    create_parser.add_argument('--latest', action='store_true', default=False)
+    create_parser.add_argument("--latest", action="store_true", default=False)
     create_parser.add_argument("--dry-run", action="store_true", default=False)
 
     upload_parser = subparsers.add_parser("upload")
@@ -31,7 +35,9 @@ def main():
     args = parser.parse_args()
 
     if args.command == "create":
-        body = create_github_release_notes(args.tag, args.commit, GARDENLINUX_GITHUB_RELEASE_BUCKET_NAME)
+        body = create_github_release_notes(
+            args.tag, args.commit, GARDENLINUX_GITHUB_RELEASE_BUCKET_NAME
+        )
         if args.dry_run:
             print("Dry Run ...")
             print("This release would be created:")

src/gardenlinux/github/release/__init__.py

@@ -27,14 +27,14 @@ def create_github_release(owner, repo, tag, commitish, latest, body):
         "body": body,
         "draft": False,
         "prerelease": False,
-        "make_latest": "true" if latest else "false"
+        "make_latest": "true" if latest else "false",
     }
 
     response = requests.post(
         f"https://api.github.com/repos/{owner}/{repo}/releases",
         headers=headers,
         data=json.dumps(data),
-        timeout=REQUESTS_TIMEOUTS
+        timeout=REQUESTS_TIMEOUTS,
     )
 
     if response.status_code == 201:
@@ -84,7 +84,9 @@ def upload_to_github_release_page(
         LOGGER.error(f"Error reading file {file_to_upload}: {e}")
         return
 
-    response = requests.post(upload_url, headers=headers, data=file_contents, timeout=REQUESTS_TIMEOUTS)
+    response = requests.post(
+        upload_url, headers=headers, data=file_contents, timeout=REQUESTS_TIMEOUTS
+    )
     if response.status_code == 201:
         LOGGER.info("Upload successful")
     else:

src/gardenlinux/github/release_notes/__init__.py

@@ -7,7 +7,9 @@
 )
 
 
-def create_github_release_notes(gardenlinux_version, commitish, releases_s3_bucket_name):
+def create_github_release_notes(
+    gardenlinux_version, commitish, releases_s3_bucket_name
+):
     package_list = get_package_list(gardenlinux_version)
 
     output = ""
@@ -20,7 +22,9 @@ def create_github_release_notes(gardenlinux_version, commitish, releases_s3_buck
         gardenlinux_version, package_list
     )
 
-    metadata_files = download_all_metadata_files(gardenlinux_version, commitish, releases_s3_bucket_name)
+    metadata_files = download_all_metadata_files(
+        gardenlinux_version, commitish, releases_s3_bucket_name
+    )
 
     output += release_notes_image_ids_section(metadata_files)
 

src/gardenlinux/github/release_notes/deployment_platform/__init__.py

@@ -1,7 +1,7 @@
 from gardenlinux.constants import GARDENLINUX_GITHUB_RELEASE_BUCKET_NAME
 
 
-class DeploymentPlatform():
+class DeploymentPlatform:
     artifacts_bucket_name = GARDENLINUX_GITHUB_RELEASE_BUCKET_NAME
 
     def short_name(self):
@@ -25,7 +25,9 @@ def image_extension(self):
         return "raw"
 
     def artifact_for_flavor(self, flavor, markdown_format=True):
-        base_url = f"https://{self.__class__.artifacts_bucket_name}.s3.amazonaws.com/objects"
+        base_url = (
+            f"https://{self.__class__.artifacts_bucket_name}.s3.amazonaws.com/objects"
+        )
         filename = f"{flavor}.{self.image_extension()}"
         download_url = f"{base_url}/{flavor}/{filename}"
         if markdown_format:
@@ -48,7 +50,9 @@ def region_details(self, image_metadata):
                             "image_id": image_id,
                             "image_name": image_name,
                         }:
-                            details += f"**{region_name}:** {image_id} ({image_name})<br>"
+                            details += (
+                                f"**{region_name}:** {image_id} ({image_name})<br>"
+                            )
                         case {"region": region_name, "image_id": image_id}:
                             details += f"**{region_name}:** {image_id}<br>"
             case {"details": details_dict}:
@@ -93,7 +97,9 @@ def summary_text(self, image_metadata):
             }:
                 gallery_count = len(gallery_images)
                 marketplace_count = len(marketplace_images)
-                return f"{gallery_count} gallery + {marketplace_count} marketplace images"
+                return (
+                    f"{gallery_count} gallery + {marketplace_count} marketplace images"
+                )
             case {"gallery_images": gallery_images}:
                 gallery_count = len(gallery_images)
                 return f"{gallery_count} gallery images"

src/gardenlinux/github/release_notes/deployment_platform/ali_cloud.py

@@ -1,3 +1,4 @@
+# pyright: reportIncompatibleMethodOverride=false
 from . import DeploymentPlatform
 
 

src/gardenlinux/github/release_notes/deployment_platform/amazon_web_services.py

@@ -1,3 +1,4 @@
+# pyright: reportIncompatibleMethodOverride=false
 from . import DeploymentPlatform
 
 

src/gardenlinux/github/release_notes/deployment_platform/azure.py

@@ -1,3 +1,4 @@
+# pyright: reportIncompatibleMethodOverride=false
 from . import DeploymentPlatform