Skip to content

Commit 3d50907

Browse files
committed
Format code and fix bandit error for md5 use in mock
1 parent a190283 commit 3d50907

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

tests/s3/test_s3_artifacts.py

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ def dummy_digest(data: bytes, algo: str) -> str:
2121
Dummy for file_digest() to compute hashes for in-memory byte streams
2222
"""
2323
content = data.read()
24-
data.seek(0) # Reset byte cursor to start for multiple uses
24+
data.seek(0) # Reset byte cursor to start for multiple uses
2525

2626
if algo == "md5":
27-
return md5(content)
27+
return md5(content) # nosec B324
2828
elif algo == "sha256":
2929
return sha256(content)
3030
else:
@@ -87,11 +87,11 @@ def all(self):
8787
def filter_side_effect(Prefix):
8888
# When fetching metadata
8989
if Prefix == "meta/singles/testcname":
90-
return [release_object] # return list with release file
90+
return [release_object] # return list with release file
9191
# When fetching actual artifact
9292
elif Prefix == "objects/testcname":
93-
return MockFilterReturn() # return mock object
94-
return [] # Nothing found
93+
return MockFilterReturn() # return mock object
94+
return [] # Nothing found
9595

9696
# Act
9797
mock_bucket.objects.filter.side_effect = filter_side_effect
@@ -217,5 +217,9 @@ def test_upload_from_directory_with_delete(mock_bucket_class, mock_digest, tmp_p
217217

218218
s3.upload_from_directory(cname, tmp_path, delete_before_push=True)
219219

220-
mock_bucket.delete_objects.assert_any_call(Delete={"Objects": [{"Key": f"objects/{cname}/{artifact.name}"}]})
221-
mock_bucket.delete_objects.assert_any_call(Delete={"Objects": [{"Key": f"meta/singles/{cname}"}]})
220+
mock_bucket.delete_objects.assert_any_call(
221+
Delete={"Objects": [{"Key": f"objects/{cname}/{artifact.name}"}]}
222+
)
223+
mock_bucket.delete_objects.assert_any_call(
224+
Delete={"Objects": [{"Key": f"meta/singles/{cname}"}]}
225+
)

0 commit comments

Comments
 (0)