Tests: Update tests to cover all changes

Author: ByteOtter

tests/s3/test_bucket.py

@@ -8,15 +8,21 @@
 """
 
 import io
-from pathlib import Path
-
-import pytest
 
 from gardenlinux.s3.bucket import Bucket
 
 REGION = "us-east-1"
 
 
+def test_bucket_minimal(s3_setup):
+    """
+    Ensure Bucket initializes correctly.
+    """
+    env = s3_setup
+    bucket = Bucket(env.bucket_name)
+    assert bucket.name == env.bucket_name
+
+
 def test_objects_empty(s3_setup):
     """
     List objects from empty bucket.

tests/s3/test_s3_artifacts.py

@@ -202,6 +202,53 @@ def test_upload_from_directory_version_mismatch_raises(s3_setup):
         artifacts.upload_from_directory(env.cname, env.tmp_path)
 
 
+def test_upload_from_directory_none_version_raises(monkeypatch, s3_setup):
+    """
+    Raise RuntimeError if CName.version is None.
+    """
+    # Arrange
+    env = s3_setup
+    (env.tmp_path / f"{env.cname}.release").write_text(RELEASE_DATA)
+
+    import gardenlinux.s3.s3_artifacts as s3art
+
+    class DummyCName:
+        arch = "amd64"
+        version = None
+        commit_id = "abc123"
+        platform = "aws"
+
+        def __init__(self, cname):
+            pass
+
+    monkeypatch.setattr(s3art, "CName", DummyCName)
+
+    artifacts = s3art.S3Artifacts(env.bucket_name)
+
+    # Act / Assert
+    with pytest.raises(RuntimeError, match="CName version could not be determined"):
+        artifacts.upload_from_directory(env.cname, env.tmp_path)
+
+
+def test_upload_from_directory_invalid_artifact_name(s3_setup):
+    """
+    Raise RuntimeError if artifact file does not start with cname.
+    """
+    # Arrange
+    env = s3_setup
+    (env.tmp_path / f"{env.cname}.release").write_text(RELEASE_DATA)
+
+    # Create "bad" artifact that does not start with cname
+    bad_file = env.tmp_path / "no_match"
+    bad_file.write_bytes(b"oops")
+
+    artifacts = S3Artifacts(env.bucket_name)
+
+    # Act / Assert
+    with pytest.raises(RuntimeError, match="does not start with cname"):
+        artifacts.upload_from_directory(env.cname, env.tmp_path)
+
+
 def test_upload_from_directory_commit_mismatch_raises(s3_setup):
     """Raise RuntimeError when commit ID is not matching with cname."""
     # Arrange