Skip to content

Commit dc3bd9f

Browse files
committed
Remove unnecessary cname_object.version is None check as it is already covered
1 parent cf80d58 commit dc3bd9f

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

src/gardenlinux/s3/s3_artifacts.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -143,9 +143,6 @@ def upload_from_directory(
143143
f"Release file data and given cname conflict detected: Commit ID {cname_object.commit_id}"
144144
)
145145

146-
if cname_object.version is None:
147-
raise RuntimeError("CName version could not be determined!")
148-
149146
commit_hash = release_config.get(UNNAMED_SECTION, "GARDENLINUX_COMMIT_ID_LONG")
150147

151148
feature_set = release_config.get(UNNAMED_SECTION, "GARDENLINUX_FEATURES")

tests/s3/test_s3_artifacts.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -212,6 +212,8 @@ def test_upload_from_directory_none_version_raises(monkeypatch, s3_setup):
212212

213213
import gardenlinux.s3.s3_artifacts as s3art
214214

215+
# Monkeypatch CName to force Cname.version to be None and avoid
216+
# class internal error checks
215217
class DummyCName:
216218
arch = "amd64"
217219
version = None

0 commit comments

Comments
 (0)