Prevent vmcli start from messing up Ctrl+C

Author: soenkehahn

spec/IntegrationSpec.hs

@@ -6,6 +6,7 @@ module IntegrationSpec where
 import Context
 import Control.Concurrent (readMVar)
 import Control.Concurrent.MVar (newEmptyMVar, putMVar)
+import Cradle qualified
 import Data.ByteString qualified as B
 import Data.Maybe (fromMaybe)
 import Data.String.Conversions
@@ -106,6 +107,14 @@ spec = around_ inTempDirectory $ do
       files <- listDirectory "."
       files `shouldBe` []
 
+  it "`vmcli start` doesn't mess up the terminal" $ do
+    withContext $ \ctx -> do
+      writeStandardFlake ctx Nothing
+      Cradle.StdoutRaw before <- Cradle.run $ Cradle.cmd "stty" & Cradle.addArgs ["-a" :: Text]
+      _ <- assertSuccess $ test ctx ["start", "server"]
+      Cradle.StdoutRaw after <- Cradle.run $ Cradle.cmd "stty" & Cradle.addArgs ["-a" :: Text]
+      after `shouldBe` before
+
   it "starts vms with arbitrary hostnames" $ do
     withContext $ \ctx -> do
       writeStandardFlake ctx (Just "{ lib, ...} : { networking.hostName = lib.mkForce \"other-hostname\"; }")

src/NixVms.hs

@@ -143,6 +143,7 @@ runVm ctx verbosity vmName vmExecutable = do
   let mkProc stdout stdin =
         (System.Process.proc vmExecutable [])
           { env = Just $ Map.toList $ Map.insert "NIX_DISK_IMAGE" nixDiskImage parentEnvironment,
+            std_in = CreatePipe,
             std_out = stdout,
             std_err = stdin
           }