Configure dogstatsd host & port at runtime

[xkrt]

Hi!

Sometimes I need to configure host and port at runtime (for example, for using remote datadog-agent in proxy mode. For now, configuration possible at compile time only.

[garrettsickles]

Given I need to add this and the unix sockets, i will do them at the same time

[ziliang-nuro]

I need the exact same thing.

Is there an ETA for the feature to land? How can I help?

[garrettsickles]

I am probably going to need to do a 2.0 release for this but that is no problem.

@ziliang-nuro or @xkrt I could use help setting up a dogstatsd yaml config so I can replicate both of your use cases. I will probably not test in a containerized environment but I will test on a vanilla ubuntu distro as I have for previous integration testing.

I will get to it this week, probably just prototype a app that successfully uses UDS.
The next step will be creating a Config model to contain the address, port, and mode.
Then I will implement in the API and it will be a breaking change, but the library needs to move in this direction.

[ziliang-nuro]

@garrettsickles I do not have a config for the client. For my use case, the config is pretty simple: I intend to pass the DD_HOST and DD_PORT as environment variable, so I would need either 1) this library understand the environment var and read from it, or 2) my program parse the host/port from environment vars and pass into a constructor or init method.

I'm running everything in Kubernetes, so I can help testing the containerize environment.

[garrettsickles]

I am working on this in a 2.0 branch.

Here is what the new API would be

Here is the source for the new API

Basically it would be used like:

// Custom UDP hostname and port
DogFood::Send(
    DogFood::Metric(...),
    DogFood::Configure(Mode::UDP, "127.0.0.1", 1234)
)

or

// Future Unix Domain Socket Support
DogFood::Send(
    DogFood::Metric(...),
    DogFood::Configure(Mode::UDS, "{path}", 12345)
)

[xkrt]

@garrettsickles
API looks a little strange for me:

DogFood::Configure(Mode::UDS, "{path}", 12345)

Port needs only for UDP and path needs only for UDS, but my code forced to pass both.
It would be more clear if I use path argument only for UDS and port only for UDP.

Not a big deal, just my opinion.

[ziliang-nuro]

IIUC, path for UDP mode represents the hostname or ip, so the API looks less strange to me.

Maybe adding this would be good:

Configuration
ConfigureUDS
(
    const Mode& _mode,
    const std::string& _path,
) {
    return std::make_tuple(_mode, _path, 0);
}

[ziliang-nuro]

@garrettsickles LGTM. Thanks! When do you expect to release?

[garrettsickles]

#19