Merge pull request #209 from gatewayapps/bug/202/fix-css-issue

fix: 202 -fix css issue

Author: johnmurphy01

app.js

@@ -1,6 +1,3 @@
-const createFilters = require('./lib/createFilters')
-const populateUrlMetadata = require('./lib/populateUrlMetadata')
-
 var token = ''
 var repoList = []
 var intervalIds = []
@@ -42,7 +39,6 @@ function initializeExtension() {
   }
 
   intervalIds.forEach(clearInterval)
-
   saveAppliedFilters({ currentRepo, issueNumber, organization, url })
 
   const kaminoButton = $(Handlebars.templates.button().replace(/(\r\n|\n|\r)/gm, ''))
@@ -120,7 +116,7 @@ function saveAppliedFilters(urlMetadata) {
         filters: [],
       },
       (item) => {
-        const filters = createFilters(newFilter, item)
+        const { filters, changed } = createFilters(newFilter, item)
 
         // only save if changed, otherwise the max quota per minute will be exceeded throwing errors
         if (changed) {

css/style.css

@@ -213,19 +213,20 @@ a {
   display: none;
 }
 
-.open {
-  display: inline;
+.sidebar-kamino .open {
+  display: block;
 }
 
 button.close {
   -webkit-appearance: none;
+  appearance: none;
   padding: 0;
   cursor: pointer;
   background: 0 0;
   border: 0;
 }
 
-.close {
+.modal-header .close {
   float: right;
   font-size: 21px;
   font-weight: 700;

lib/createFilters.js

@@ -21,7 +21,7 @@ function createFilters(newFilter, item) {
     item.filters.push(newFilter)
   }
 
-  return item.filters
+  return { filters: item.filters, changed }
 }
 
-module.exports = createFilters
+module.exports = createFilters;

lib/populateUrlMetadata.js

@@ -18,4 +18,4 @@ function populateUrlMetadata(href) {
   return { error: 'Cannot parse this url' }
 }
 
-module.exports = populateUrlMetadata
+module.exports = populateUrlMetadata;

manifest.json

@@ -4,14 +4,28 @@
     {
       "matches": ["*://github.com/*/*/issues"],
       "exclude_matches": ["*://github.com/*/*/issues/*"],
-      "js": ["./jquery/jquery-3.6.0.min.js", "./handlebars.runtime.min-v4.7.7.js", "./batch.js", "./template.js"],
+      "js": [
+        "./jquery/jquery-3.6.0.min.js",
+        "./handlebars.runtime.min-v4.7.7.js",
+        "./lib/populateUrlMetadata.js",
+        "./lib/createFilters.js",
+        "./batch.js",
+        "./template.js"
+      ],
       "css": ["./css/style.css"],
       "run_at": "document_end"
     },
     {
       "matches": ["*://github.com/*/*/issues/*"],
       "exclude_matches": ["*://github.com/*/*/issues"],
-      "js": ["./jquery/jquery-3.6.0.min.js", "./handlebars.runtime.min-v4.7.7.js", "./app.js", "./template.js"],
+      "js": [
+        "./jquery/jquery-3.6.0.min.js",
+        "./handlebars.runtime.min-v4.7.7.js",
+        "./lib/populateUrlMetadata.js",
+        "./lib/createFilters.js",
+        "./app.js",
+        "./template.js"
+      ],
       "css": ["./css/style.css"],
       "run_at": "document_end"
     }
@@ -28,7 +42,7 @@
   "options_page": "options.html",
   "permissions": ["tabs", "background", "scripting", "storage", "webNavigation"],
   "host_permissions": ["*://github.com/*"],
-  "version": "4.0.0",
+  "version": "4.0.1",
   "web_accessible_resources": [
     {
       "resources": [
@@ -38,6 +52,8 @@
         "./css/options.css",
         "jquery/jquery-3.6.0.min.js",
         "handlebars.runtime.min-v4.7.7.js",
+        "lib/populateUrlMetadata.js",
+        "lib/createFilters.js",
         "template.js",
         "app.js",
         "options.html",

tests/createFilters.spec.js

@@ -18,8 +18,9 @@ describe('createFilter', () => {
       ],
     }
 
-    const filters = createFilters(newFilter, existingFilters)
+    const {changed, filters} = createFilters(newFilter, existingFilters)
     expect(filters).toHaveLength(2)
+    expect(changed).toBeTruthy()
     expect(filters[1].filter).toEqual('test-filter')
   })
 
@@ -40,8 +41,9 @@ describe('createFilter', () => {
       ],
     }
 
-    const filters = createFilters(newFilter, existingFilters)
+    const {changed, filters} = createFilters(newFilter, existingFilters)
     expect(filters).toHaveLength(1)
+    expect(changed).toBeTruthy()
     expect(filters[0].filter).toEqual('test-filter')
   })
 
@@ -62,8 +64,9 @@ describe('createFilter', () => {
       ],
     }
 
-    const filters = createFilters(newFilter, existingFilters)
+    const {changed, filters} = createFilters(newFilter, existingFilters)
     expect(filters).toHaveLength(1)
+    expect(changed).toEqual(false)
     expect(filters[0].filter).toEqual('test-filter')
   })
 })