fix: use forked devcert to avoid pulling transitive deps from its @types/* deps, handle change in tmp package (#39343)

* fix: use forked devcert to avoid pulling transitive deps from its @types/* deps

* chore: remove cpy from structured-logging test

* chore: remove del-cli from cli test

* chore: use gatsbyjs fork and not private one

* chore: use @expo/devcert as it is being maintained

* fix: create .cache directory before trying to create temp file in it

Author: pieh

integration-tests/gatsby-cli/__tests__/new.js

@@ -1,6 +1,5 @@
 import { GatsbyCLI } from "../test-helpers"
 import * as fs from "fs-extra"
-import execa from "execa"
 import { join } from "path"
 import { getConfigStore } from "gatsby-core-utils"
 
@@ -9,7 +8,14 @@ jest.setTimeout(MAX_TIMEOUT)
 
 const cwd = `execution-folder`
 
-const clean = dir => execa(`yarn`, ["del-cli", dir])
+const clean = async dir => {
+  try {
+    await fs.rmdir(dir, { recursive: true })
+  } catch {
+    // will throw when dir doesn't exist
+    // which is fine, we just want to ensure it's clean
+  }
+}
 
 describe(`gatsby new`, () => {
   // make folder for us to create sites into

integration-tests/gatsby-cli/package.json

@@ -8,7 +8,6 @@
   "devDependencies": {
     "babel-jest": "^29.3.1",
     "babel-preset-gatsby-package": "next",
-    "del-cli": "^3.0.1",
     "execa": "^4.0.1",
     "fs-extra": "^9.0.0",
     "gatsby": "next",

integration-tests/structured-logging/__tests__/to-do.js

@@ -7,7 +7,6 @@ const EventEmitter = require(`events`)
 const fetch = require(`node-fetch`)
 const fs = require(`fs-extra`)
 const path = require(`path`)
-const cpy = require(`cpy`)
 const { first, last } = require(`lodash`)
 // const { groupBy, filter } = require(`lodash`)
 const joi = require(`joi`)
@@ -380,7 +379,7 @@ describe(`develop`, () => {
 
     describe(`code change`, () => {
       beforeAll(() => {
-        return cpy(
+        return fs.cp(
           path.join(__dirname, "../src/pages/index.js"),
           path.join(__dirname, "../original/"),
           {
@@ -428,12 +427,12 @@ describe(`develop`, () => {
         commonAssertionsForFailure(events)
       })
       describe(`valid`, () => {
-        beforeAll(done => {
+        beforeAll(async done => {
           clearEvents()
 
-          cpy(
+          await fs.cp(
             path.join(__dirname, "../original/index.js"),
-            path.join(__dirname, "../src/pages/"),
+            path.join(__dirname, "../src/pages/index.js"),
             {
               overwrite: true,
             }

integration-tests/structured-logging/package.json

@@ -17,7 +17,6 @@
   },
   "devDependencies": {
     "babel-plugin-dynamic-import-node-sync": "^2.0.1",
-    "cpy": "^8.1.2",
     "fs-extra": "^10.0.0",
     "jest": "^29.3.1",
     "joi": "^17.4.0",

packages/gatsby/package.json

@@ -19,6 +19,7 @@
     "@babel/traverse": "^7.20.13",
     "@babel/types": "^7.20.7",
     "@builder.io/partytown": "^0.7.5",
+    "@expo/devcert": "^1.2.0",
     "@gatsbyjs/reach-router": "^2.0.1",
     "@gatsbyjs/webpack-hot-middleware": "^2.25.3",
     "@graphql-codegen/add": "^3.2.3",
@@ -69,7 +70,6 @@
     "debug": "^4.3.4",
     "deepmerge": "^4.3.1",
     "detect-port": "^1.5.1",
-    "devcert": "^1.2.2",
     "dotenv": "^8.6.0",
     "enhanced-resolve": "^5.15.0",
     "error-stack-parser": "^2.1.4",

packages/gatsby/src/commands/develop.ts

@@ -57,8 +57,11 @@ class ControllableScript {
   }
   start(): void {
     const args: Array<string> = []
+
+    const dotCachePath = path.join(process.cwd(), `.cache`)
+    fs.mkdirpSync(dotCachePath)
     const tmpFileName = tmp.tmpNameSync({
-      tmpdir: path.join(process.cwd(), `.cache`),
+      tmpdir: dotCachePath,
     })
     fs.outputFileSync(tmpFileName, this.script)
     this.isRunning = true

packages/gatsby/src/utils/__tests__/get-ssl-cert.ts

@@ -11,13 +11,13 @@ jest.mock(`gatsby-cli/lib/reporter`, () => {
     info: jest.fn(),
   }
 })
-jest.mock(`devcert`, () => {
+jest.mock(`@expo/devcert`, () => {
   return {
     certificateFor: jest.fn(),
   }
 })
 
-import { certificateFor as getDevCert } from "devcert"
+import { certificateFor as getDevCert } from "@expo/devcert"
 import reporter from "gatsby-cli/lib/reporter"
 import { getSslCert, IGetSslCertArgs } from "../get-ssl-cert"
 

packages/gatsby/src/utils/get-ssl-cert.ts

@@ -86,7 +86,7 @@ export async function getSslCert({
       const mkdtemp = fs.mkdtempSync(path.join(os.tmpdir(), `home-`))
       process.env.HOME = mkdtemp
     }
-    const getDevCert = require(`devcert`).certificateFor
+    const getDevCert = require(`@expo/devcert`).certificateFor
     const { caPath, key, cert } = await getDevCert(name, {
       getCaPath: true,
       skipCertutilInstall: false,