[gatsby] gatsby serve cache paramaters

[moonmeister]

Description

For anyone using gatsby serve cache headers are not being set correctly.

Steps to reproduce

1. using any Gatsby site
2. gatsby build
3. gatsby serve
4. Open dev tools network tab and check the response headers for all requested files at. localhost:9000

Expected result

I'd expect Gatsby's provided server implementation to follow best practices.
https://www.gatsbyjs.com/docs/caching/

Actual result

Gatsby serve appears to set cache headers as public, max-age=0 for all files which is wrong according to https://www.gatsbyjs.com/docs/caching/.

Environment

  System:
    OS: macOS 10.15.7
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 14.17.0 - ~/.nvm/versions/node/v14.17.0/bin/node
    Yarn: 1.22.10 - ~/.nvm/versions/node/v14.17.0/bin/yarn
    npm: 6.14.13 - ~/.nvm/versions/node/v14.17.0/bin/npm
  Languages:
    Python: 2.7.16 - /usr/bin/python
  Browsers:
    Chrome: 90.0.4430.212
    Firefox: 88.0.1
    Safari: 14.1
  npmPackages:
    gatsby: ^3.4.1 => 3.5.1 
    gatsby-plugin-image: ^1.5.0 => 1.5.0 
    gatsby-plugin-manifest: ^3.5.0 => 3.5.0 
    gatsby-plugin-postcss: ^4.5.0 => 4.5.0 
    gatsby-plugin-react-helmet: ^4.5.0 => 4.5.0 
    gatsby-plugin-sharp: ^3.5.0 => 3.5.0 
    gatsby-plugin-sitemap: ^4.1.0 => 4.1.0 
    gatsby-source-filesystem: ^3.5.0 => 3.5.0 
    gatsby-source-wordpress: ^5.5.1 => 5.5.1 
    gatsby-transformer-sharp: ^3.5.0 => 3.5.0 

[vladar]

Hey @moonmeister 👋

I think gatsby serve is not supposed to be used in production. But it would be nice if it was behaving as we recommend. So any improvements are welcome. If anyone is interested - feel free to open a PR.

Also, to clarify this a bit - which part doesn't work as you would expect. Caching headers for static assets? Something else?

[github-actions[bot]]

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜