Should slice-data respect assetPrefix?

[mudge]

We've just deployed our first use of the Slice API and notice requests being made to /slice-data/header.json and /slice-data/footer.json on our main domain. This required changes to our load balancer as we expected those files to be served from our dedicated asset host (ala files under /page-data/) as defined by the assetPrefix configuration variable.

Should slice-data also be served with the asset prefix?

[mudge]

Specifically, should

gatsby/packages/gatsby/cache-dir/loader.js

Line 330 in 33976b3

const url = `/slice-data/${sliceName}.json`

use __PATH_PREFIX__ ala

gatsby/packages/gatsby/cache-dir/loader.js

Line 31 in 33976b3

return `${__PATH_PREFIX__}/page-data/${fixedPath}/page-data.json${

?

[pieh]

Yes, I think you are completely right @mudge - we should use same setup for slice-data as one we do for page-data. Are you willing to open PR with the fix?

[mudge]

Raised a PR at #37202