Skip to content

Commit 16ff3b8

Browse files
authored
ci: run cppcheck, cpplint on noble (#669)
Fix cpplint: line length, whitespace Signed-off-by: Steve Peters <[email protected]>
1 parent 8f235cb commit 16ff3b8

File tree

4 files changed

+11
-4
lines changed

4 files changed

+11
-4
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,3 +29,8 @@ jobs:
2929
- name: Compile and test
3030
id: ci
3131
uses: gazebo-tooling/action-gz-ci@noble
32+
with:
33+
# codecov-enabled: true
34+
cppcheck-enabled: true
35+
cpplint-enabled: true
36+
# doxygen-enabled: true

graphics/src/AssimpLoader.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -613,7 +613,8 @@ ImagePtr AssimpLoader::Implementation::LoadEmbeddedTexture(
613613
{
614614
if (_texture->mHeight == 0)
615615
{
616-
Image::PixelFormatType format = Image::PixelFormatType::UNKNOWN_PIXEL_FORMAT;
616+
Image::PixelFormatType format =
617+
Image::PixelFormatType::UNKNOWN_PIXEL_FORMAT;
617618
if (_texture->CheckFormat("png"))
618619
{
619620
format = Image::PixelFormatType::COMPRESSED_PNG;

graphics/src/AssimpLoader_TEST.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -791,7 +791,8 @@ TEST_F(AssimpLoader, LoadGlbPbrAsset)
791791
EXPECT_NE(pbr->RoughnessMapData(), nullptr);
792792
// Check pixel values to test metallicroughness texture splitting
793793
EXPECT_FLOAT_EQ(pbr->MetalnessMapData()->Pixel(256, 256).R(), 0.0f);
794-
EXPECT_FLOAT_EQ(pbr->RoughnessMapData()->Pixel(256, 256).R(), 124.0f / 255.0f);
794+
EXPECT_FLOAT_EQ(pbr->RoughnessMapData()->Pixel(256, 256).R(),
795+
124.0f / 255.0f);
795796

796797
// Bug in assimp 5.0.x that doesn't parse coordinate sets properly
797798
// \todo(iche033) Lightmaps are disabled for glb meshes

include/gz/common/Console.hh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,11 +129,11 @@ namespace gz
129129
/// \return True when the initialization succeed or false otherwise.
130130
public: static bool Init(const std::string &_directory,
131131
const std::string &_filename);
132-
132+
133133
/// \brief Detach fhe file sink from the global logger. After this call,
134134
/// console logging will keep working but no file logging.
135135
public: static void Close();
136-
136+
137137
/// \brief Get the full path of the directory where all the log files
138138
/// are stored.
139139
/// \return Full path of the directory.

0 commit comments

Comments
 (0)