Deprecate MovingWindowFilter, use gz-math instead (#692)

Signed-off-by: Steve Peters <[email protected]>

Author: scpeters

Migration.md

@@ -5,6 +5,17 @@ Deprecated code produces compile-time warnings. These warning serve as
 notification to users that their code should be upgraded. The next major
 release will remove the deprecated code.
 
+## Gazebo Common 6.X to 7.X
+
+1. The major version has been removed from the cmake project name and the
+   package.xml package name. Use `find_package(gz-common)` instead of
+   `find_package(gz-commonX)` going forward.
+
+### Deprecations
+
+1. `gz::common::MovingWindowFilter` is deprecated since the functionality
+   was moved to gz-math. Please use `gz::math::MovingWindowFilter` instead.
+
 ## Gazebo Common 5.X to 6.X
 
 ### Modifications

include/gz/common/MovingWindowFilter.hh

@@ -19,6 +19,7 @@
 
 #include <memory>
 #include <vector>
+#include <gz/common/Export.hh>
 
 namespace gz
 {
@@ -65,10 +66,10 @@ namespace gz
     class MovingWindowFilter
     {
       /// \brief Constructor
-      public: MovingWindowFilter();
+      public: GZ_DEPRECATED(7) MovingWindowFilter();
 
       /// \brief Destructor
-      public: virtual ~MovingWindowFilter();
+      public: GZ_DEPRECATED(7) virtual ~MovingWindowFilter();
 
       /// \brief Update value of filter
       /// \param[in] _val new raw value
@@ -92,7 +93,7 @@ namespace gz
 
       /// \brief Allow subclasses to initialize their own data pointer.
       /// \param[in] _d Reference to data pointer.
-      protected: explicit MovingWindowFilter<T>(
+      protected: GZ_DEPRECATED(7) explicit MovingWindowFilter(
                      MovingWindowFilterPrivate<T> &_d);
 
       /// \brief Data pointer.

src/MovingWindowFilter_TEST.cc

@@ -17,11 +17,14 @@
 
 #include <gtest/gtest.h>
 #include <gz/math/Vector3.hh>
+#include <gz/utils/SuppressWarning.hh>
 
 #include "gz/common/MovingWindowFilter.hh"
 
 using namespace gz;
 
+GZ_UTILS_WARN_IGNORE__DEPRECATED_DECLARATION
+
 /////////////////////////////////////////////////
 TEST(MovingWindowFilterTest, SetWindowSize)
 {
@@ -69,3 +72,4 @@ TEST(MovingWindowFilterTest, FilterSomething)
         3.0*static_cast<double>(i));
   EXPECT_EQ(vectorMWF.Value(), vsum / 20.0);
 }
+GZ_UTILS_WARN_RESUME__DEPRECATED_DECLARATION