Fix error output when creating directories (#561)

mjcarroll · web-flow · commit e899db548747 · 2023-12-04T10:51:29.000-06:00
Signed-off-by: Michael Carroll &lt;mjcarroll@intrinsic.ai&gt;
diff --git a/src/Filesystem.cc b/src/Filesystem.cc
@@ -466,11 +466,16 @@ bool common::copyDirectory(const std::string &_existingDirname,
 /////////////////////////////////////////////////
 bool common::createDirectories(const std::string &_path)
 {
-  return createDirectories(_path, ignerr);
+  std::ostringstream ss;
+  auto ret = createDirectories(_path, ss);
+  if (!ret)
+    ignerr << ss.str();
+  return ret;
 }
 
 /////////////////////////////////////////////////
-bool common::createDirectories(const std::string &_path, std::ostream &_errorOut)
+bool common::createDirectories(
+  const std::string &_path, std::ostream &_errorOut)
 {
   size_t index = 0;
   while (index < _path.size())

Original file line number	Diff line number	Diff line change
`@@ -466,11 +466,16 @@ bool common::copyDirectory(const std::string &_existingDirname,`
`466`	`466`	`/////////////////////////////////////////////////`
`467`	`467`	`bool common::createDirectories(const std::string &_path)`
`468`	`468`	`{`
`469`		`- return createDirectories(_path, ignerr);`
	`469`	`+ std::ostringstream ss;`
	`470`	`+ auto ret = createDirectories(_path, ss);`
	`471`	`+ if (!ret)`
	`472`	`+ ignerr << ss.str();`
	`473`	`+ return ret;`
`470`	`474`	`}`
`471`	`475`
`472`	`476`	`/////////////////////////////////////////////////`
`473`		`-bool common::createDirectories(const std::string &_path, std::ostream &_errorOut)`
	`477`	`+bool common::createDirectories(`
	`478`	`+ const std::string &_path, std::ostream &_errorOut)`
`474`	`479`	`{`
`475`	`480`	`size_t index = 0;`
`476`	`481`	`while (index < _path.size())`