:farmer: gz_msgs-ci-ign-msgs8/10-homebrew clang build warning regarding `RepeatedPtrField` deprecation in mac sonoma

[miguelgonrod]

Environment

• OS Version: mac sonoma
• Source

Description

• Expected behavior: To build without warnings
• Actual behavior: Building with warnings

Steps to reproduce

1. Go to gz_msgs-ci-ign-msgs8-homebrew-amd64 or gz_msgs-ci-gz-msgs10-homebrew-amd64
2. Build a job
3. See the warnings

Output

/usr/local/include/google/protobuf/map_field.h:416:11: warning: 'RepeatedPtrField' is deprecated: Use Arena::Create<RepeatedPtrField<...>>(Arena*) instead [-Wdeprecated-declarations]
  416 |         : repeated_field_(arena), prototype_(prototype) {}
      |           ^
/usr/local/include/google/protobuf/repeated_ptr_field.h:1035:5: note: 'RepeatedPtrField' has been explicitly marked deprecated here
 1035 |   [[deprecated("Use Arena::Create<RepeatedPtrField<...>>(Arena*) instead")]]
      |     ^
1 warning generated.

CC: @Crola1702

[scpeters]

I don't know why these warnings are appearing with amd64 but not arm64

regarding the version difference, I see that some deprecation warning suppression was added to gz-msgs11 in 7f647da (part of #451) that is not present in earlier versions. I don't understand exactly what is happening, so I'm not sure if that is the reason we aren't seeing these warnings with newer versions

[scpeters]

I was able to reproduce the compiler warnings on my amd64 machine, and I opened #553 to backport suppression of the warnings

[scpeters]

I took another look at how to backport the compiler warnings suppression to Fortress in #556, but it's a very tricky backport due to the refactoring. I think we should consider a different suppression approach even if it is more heavy-handed

[azeey]

@azeey to post about gz-cmake change needed to ensure system headers are included with -isystem.

[scpeters]

I see that target_include_directories has a SYSTEM keyword, but I believe we get the protobuf headers from target_link_libraries. This might be tricky to implement

[azeey]

The gz-cmake change I was referring to is in https://github.com/gazebosim/gz-cmake/blob/639bf7f588a579a2a8d348628e458b7f936f794b/cmake/GzImportTarget.cmake#L112-L134. What I found is that the first if block adds the include directories with -isystem, but the second if block adds the same include directories with -I. As I mentioned in gazebosim/gz-common#739, depending on the compiler version and OS combination, the -isystem might be overriden by -I.

On my arm64 machine, I see that protobuf is installed in /opt/homebrew/include and that directory uses -isystem on the build targets. I use Ninja which makes this easier to see:

build src/CMakeFiles/ignition-msgs8.dir/__/include/ignition/msgs/actor.pb.cc.o: CXX_COMPILER__ignition-msgs8_unscanned_RelWithDebInfo /Users/addisuzt/ws/fortress/build/ignition-msgs8/include/ignition/msgs/actor.pb.cc || cmake_object_order_depends_target_ignition-msgs8
  CONFIG = RelWithDebInfo
  DEFINES = -DMAC_OS_X_VERSION=1080 -DPROTOBUF_USE_DLLS -Dignition_msgs8_EXPORTS
  DEP_FILE = src/CMakeFiles/ignition-msgs8.dir/__/include/ignition/msgs/actor.pb.cc.o.d
  FLAGS = -stdlib=libc++ -O2 -g -DNDEBUG -std=c++17 -arch arm64 -fPIC -Wno-extended-offsetof -I/opt/homebrew/Cellar/tinyxml2/11.0.0/include -Wno-switch-default
  INCLUDES = -I/Users/addisuzt/ws/fortress/src/gz-msgs/include -I/Users/addisuzt/ws/fortress/build/ignition-msgs8/include -I/Users/addisuzt/ws/fortress/build/ignition-msgs8/core/include -I/Users/addisuzt/ws/fortress/build/ignition-msgs8/src -isystem /opt/homebrew/include -isystem /Users/addisuzt/ws/fortress/install/include/ignition/math6 -isystem /opt/homebrew/Cellar/tinyxml2/11.0.0/include
  LAUNCHER = ccache 
  OBJECT_DIR = src/CMakeFiles/ignition-msgs8.dir
  OBJECT_FILE_DIR = src/CMakeFiles/ignition-msgs8.dir/__/include/ignition/msgs
  TARGET_COMPILE_PDB = src/CMakeFiles/ignition-msgs8.dir/
  TARGET_PDB = lib/libignition-msgs8.pdb
  TARGET_SUPPORT_DIR = src/CMakeFiles/ignition-msgs8.dir

@scpeters would you be able to configure cmake with -GNinja and post one a snippet similar to the one above for comparision?