Add sanity check for valid submesh indices (#1123) (#1125)

(cherry picked from commit ef1d5a1)

Signed-off-by: Ian Chen <[email protected]>
Co-authored-by: Ian Chen <[email protected]>

Author: mergify[bot]

ogre/src/OgreMeshFactory.cc

@@ -231,6 +231,26 @@ bool OgreMeshFactory::LoadImpl(const MeshDescriptor &_desc)
         continue;
       }
 
+      // todo(iche033) use SubMesh::HasValidIndices() when gz-common 6.0.3
+      // is released
+      bool validIndices = true;
+      for (unsigned int j = 0u; j < s->IndexCount(); ++j)
+      {
+        int index = s->Index(j);
+        if (index > 0 && static_cast<unsigned int>(index) >= s->VertexCount())
+        {
+          validIndices = false;
+          break;
+        }
+      }
+      if (!validIndices)
+      {
+        gzwarn << "Mesh[" << _desc.mesh->Name() << "] submesh[" << s->Name()
+               << "] has invalid indices. Skipping submesh creation."
+               << std::endl;
+        continue;
+      }
+
       Ogre::SubMesh *ogreSubMesh;
       Ogre::VertexData *vertexData;
       Ogre::VertexDeclaration* vertexDecl;

ogre2/src/Ogre2MeshFactory.cc

@@ -286,6 +286,26 @@ bool Ogre2MeshFactory::LoadImpl(const MeshDescriptor &_desc)
         continue;
       }
 
+      // todo(iche033) use SubMesh::HasValidIndices() when gz-common 6.0.3
+      // is released
+      bool validIndices = true;
+      for (unsigned int j = 0u; j < s->IndexCount(); ++j)
+      {
+        int index = s->Index(j);
+        if (index > 0 && static_cast<unsigned int>(index) >= s->VertexCount())
+        {
+          validIndices = false;
+          break;
+        }
+      }
+      if (!validIndices)
+      {
+        gzwarn << "Mesh[" << _desc.mesh->Name() << "] submesh[" << s->Name()
+               << "] has invalid indices. Skipping submesh creation."
+               << std::endl;
+        continue;
+      }
+
       Ogre::v1::SubMesh *ogreSubMesh;
       Ogre::v1::VertexData *vertexData;
       Ogre::v1::VertexDeclaration* vertexDecl;