Suppress dll-interface warnings (C4251) on windows

iche033 · web-flow · commit b7a9a47e0608 · 2025-02-14T13:13:24.000-08:00
Signed-off-by: Ian Chen &lt;ichen@openrobotics.org&gt;
diff --git a/ogre2/include/gz/rendering/ogre2/Ogre2DynamicRenderable.hh b/ogre2/include/gz/rendering/ogre2/Ogre2DynamicRenderable.hh
@@ -33,6 +33,13 @@
   #pragma warning(pop)
 #endif
 
+#ifdef _MSC_VER
+  #pragma warning(push)
+  // Suppress dll-interface warning. This should no longer be needed in
+  // gz-rendering9 as visibility changed hidden by default.
+  #pragma warning(disable:4251)
+#endif
+
 namespace Ogre
 {
   class MovableObject;
@@ -154,4 +161,9 @@ namespace gz
     }
   }
 }
+
+#ifdef _MSC_VER
+  #pragma warning(pop)
+#endif
+
 #endif
diff --git a/ogre2/include/gz/rendering/ogre2/Ogre2GaussianNoisePass.hh b/ogre2/include/gz/rendering/ogre2/Ogre2GaussianNoisePass.hh
@@ -23,6 +23,13 @@
 #include "gz/rendering/ogre2/Ogre2RenderPass.hh"
 #include "gz/rendering/ogre2/Export.hh"
 
+#ifdef _MSC_VER
+  #pragma warning(push)
+  // Suppress dll-interface warning. This should no longer be needed in
+  // gz-rendering9 as visibility changed hidden by default.
+  #pragma warning(disable:4251)
+#endif
+
 namespace gz
 {
   namespace rendering
@@ -57,4 +64,9 @@ namespace gz
     }
   }
 }
+
+#ifdef _MSC_VER
+  #pragma warning(pop)
+#endif
+
 #endif
diff --git a/ogre2/include/gz/rendering/ogre2/Ogre2GlobalIlluminationCiVct.hh b/ogre2/include/gz/rendering/ogre2/Ogre2GlobalIlluminationCiVct.hh
@@ -24,6 +24,13 @@
 
 #include <memory>
 
+#ifdef _MSC_VER
+  #pragma warning(push)
+  // Suppress dll-interface warning. This should no longer be needed in
+  // gz-rendering9 as visibility changed hidden by default.
+  #pragma warning(disable:4251)
+#endif
+
 namespace Ogre
 {
   class HlmsPbs;
@@ -230,4 +237,9 @@ namespace gz
     }
   }
 }
+
+#ifdef _MSC_VER
+  #pragma warning(pop)
+#endif
+
 #endif
diff --git a/ogre2/include/gz/rendering/ogre2/Ogre2GlobalIlluminationVct.hh b/ogre2/include/gz/rendering/ogre2/Ogre2GlobalIlluminationVct.hh
@@ -24,6 +24,13 @@
 
 #include <memory>
 
+#ifdef _MSC_VER
+  #pragma warning(push)
+  // Suppress dll-interface warning. This should no longer be needed in
+  // gz-rendering9 as visibility changed hidden by default.
+  #pragma warning(disable:4251)
+#endif
+
 namespace Ogre
 {
   class HlmsPbs;
@@ -148,4 +155,9 @@ namespace gz
     }
   }
 }
+
+#ifdef _MSC_VER
+  #pragma warning(pop)
+#endif
+
 #endif
diff --git a/ogre2/include/gz/rendering/ogre2/Ogre2LensFlarePass.hh b/ogre2/include/gz/rendering/ogre2/Ogre2LensFlarePass.hh
@@ -27,6 +27,13 @@
 #include "gz/rendering/ogre2/Export.hh"
 #include "gz/rendering/ogre2/Ogre2RenderPass.hh"
 
+#ifdef _MSC_VER
+  #pragma warning(push)
+  // Suppress dll-interface warning. This should no longer be needed in
+  // gz-rendering9 as visibility changed hidden by default.
+  #pragma warning(disable:4251)
+#endif
+
 namespace gz
 {
   namespace rendering
@@ -101,4 +108,9 @@ namespace gz
     }
   }
 }
+
+#ifdef _MSC_VER
+  #pragma warning(pop)
+#endif
+
 #endif
diff --git a/ogre2/include/gz/rendering/ogre2/Ogre2Object.hh b/ogre2/include/gz/rendering/ogre2/Ogre2Object.hh
@@ -22,6 +22,13 @@
 #include "gz/rendering/ogre2/Ogre2RenderTypes.hh"
 #include "gz/rendering/ogre2/Export.hh"
 
+#ifdef _MSC_VER
+  #pragma warning(push)
+  // Suppress dll-interface warning. This should no longer be needed in
+  // gz-rendering9 as visibility changed hidden by default.
+  #pragma warning(disable:4251)
+#endif
+
 namespace gz
 {
   namespace rendering
@@ -50,4 +57,9 @@ namespace gz
     }
   }
 }
+
+#ifdef _MSC_VER
+  #pragma warning(pop)
+#endif
+
 #endif
diff --git a/ogre2/include/gz/rendering/ogre2/Ogre2RenderPass.hh b/ogre2/include/gz/rendering/ogre2/Ogre2RenderPass.hh
@@ -24,6 +24,14 @@
 #include "gz/rendering/ogre2/Export.hh"
 #include "gz/rendering/ogre2/Ogre2Object.hh"
 
+
+#ifdef _MSC_VER
+  #pragma warning(push)
+  // Suppress dll-interface warning. This should no longer be needed in
+  // gz-rendering9 as visibility changed to hidden by default.
+  #pragma warning(disable:4251)
+#endif
+
 namespace Ogre
 {
   class CompositorWorkspace;
@@ -92,4 +100,9 @@ namespace gz
     }
   }
 }
+
+#ifdef _MSC_VER
+  #pragma warning(pop)
+#endif
+
 #endif
diff --git a/ogre2/include/gz/rendering/ogre2/Ogre2RenderTargetMaterial.hh b/ogre2/include/gz/rendering/ogre2/Ogre2RenderTargetMaterial.hh
@@ -35,6 +35,9 @@
   #pragma warning(push)
   // Silence deriving from Ogre::RenderTargetListener dll-linkage warnings
   #pragma warning(disable:4275)
+  // Suppress dll-interface warning. This should no longer be needed in
+  // gz-rendering9 as visibility changed hidden by default.
+  #pragma warning(disable:4251)
 #endif
 
 namespace gz

Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,13 @@`
`33`	`33`	`#pragma warning(pop)`
`34`	`34`	`#endif`
`35`	`35`
	`36`	`+#ifdef _MSC_VER`
	`37`	`+ #pragma warning(push)`
	`38`	`+ // Suppress dll-interface warning. This should no longer be needed in`
	`39`	`+ // gz-rendering9 as visibility changed hidden by default.`
	`40`	`+ #pragma warning(disable:4251)`
	`41`	`+#endif`
	`42`	`+`
`36`	`43`	`namespace Ogre`
`37`	`44`	`{`
`38`	`45`	`class MovableObject;`
`@@ -154,4 +161,9 @@ namespace gz`
`154`	`161`	`}`
`155`	`162`	`}`
`156`	`163`	`}`
	`164`	`+`
	`165`	`+#ifdef _MSC_VER`
	`166`	`+ #pragma warning(pop)`
	`167`	`+#endif`
	`168`	`+`
`157`	`169`	`#endif`
Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,13 @@`
`23`	`23`	`#include "gz/rendering/ogre2/Ogre2RenderPass.hh"`
`24`	`24`	`#include "gz/rendering/ogre2/Export.hh"`
`25`	`25`
	`26`	`+#ifdef _MSC_VER`
	`27`	`+ #pragma warning(push)`
	`28`	`+ // Suppress dll-interface warning. This should no longer be needed in`
	`29`	`+ // gz-rendering9 as visibility changed hidden by default.`
	`30`	`+ #pragma warning(disable:4251)`
	`31`	`+#endif`
	`32`	`+`
`26`	`33`	`namespace gz`
`27`	`34`	`{`
`28`	`35`	`namespace rendering`
`@@ -57,4 +64,9 @@ namespace gz`
`57`	`64`	`}`
`58`	`65`	`}`
`59`	`66`	`}`
	`67`	`+`
	`68`	`+#ifdef _MSC_VER`
	`69`	`+ #pragma warning(pop)`
	`70`	`+#endif`
	`71`	`+`
`60`	`72`	`#endif`
Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,13 @@`
`24`	`24`
`25`	`25`	`#include <memory>`
`26`	`26`
	`27`	`+#ifdef _MSC_VER`
	`28`	`+ #pragma warning(push)`
	`29`	`+ // Suppress dll-interface warning. This should no longer be needed in`
	`30`	`+ // gz-rendering9 as visibility changed hidden by default.`
	`31`	`+ #pragma warning(disable:4251)`
	`32`	`+#endif`
	`33`	`+`
`27`	`34`	`namespace Ogre`
`28`	`35`	`{`
`29`	`36`	`class HlmsPbs;`
`@@ -230,4 +237,9 @@ namespace gz`
`230`	`237`	`}`
`231`	`238`	`}`
`232`	`239`	`}`
	`240`	`+`
	`241`	`+#ifdef _MSC_VER`
	`242`	`+ #pragma warning(pop)`
	`243`	`+#endif`
	`244`	`+`
`233`	`245`	`#endif`
Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,13 @@`
`27`	`27`	`#include "gz/rendering/ogre2/Export.hh"`
`28`	`28`	`#include "gz/rendering/ogre2/Ogre2RenderPass.hh"`
`29`	`29`
	`30`	`+#ifdef _MSC_VER`
	`31`	`+ #pragma warning(push)`
	`32`	`+ // Suppress dll-interface warning. This should no longer be needed in`
	`33`	`+ // gz-rendering9 as visibility changed hidden by default.`
	`34`	`+ #pragma warning(disable:4251)`
	`35`	`+#endif`
	`36`	`+`
`30`	`37`	`namespace gz`
`31`	`38`	`{`
`32`	`39`	`namespace rendering`
`@@ -101,4 +108,9 @@ namespace gz`
`101`	`108`	`}`
`102`	`109`	`}`
`103`	`110`	`}`
	`111`	`+`
	`112`	`+#ifdef _MSC_VER`
	`113`	`+ #pragma warning(pop)`
	`114`	`+#endif`
	`115`	`+`
`104`	`116`	`#endif`
Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,13 @@`
`22`	`22`	`#include "gz/rendering/ogre2/Ogre2RenderTypes.hh"`
`23`	`23`	`#include "gz/rendering/ogre2/Export.hh"`
`24`	`24`
	`25`	`+#ifdef _MSC_VER`
	`26`	`+ #pragma warning(push)`
	`27`	`+ // Suppress dll-interface warning. This should no longer be needed in`
	`28`	`+ // gz-rendering9 as visibility changed hidden by default.`
	`29`	`+ #pragma warning(disable:4251)`
	`30`	`+#endif`
	`31`	`+`
`25`	`32`	`namespace gz`
`26`	`33`	`{`
`27`	`34`	`namespace rendering`
`@@ -50,4 +57,9 @@ namespace gz`
`50`	`57`	`}`
`51`	`58`	`}`
`52`	`59`	`}`
	`60`	`+`
	`61`	`+#ifdef _MSC_VER`
	`62`	`+ #pragma warning(pop)`
	`63`	`+#endif`
	`64`	`+`
`53`	`65`	`#endif`
Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,14 @@`
`24`	`24`	`#include "gz/rendering/ogre2/Export.hh"`
`25`	`25`	`#include "gz/rendering/ogre2/Ogre2Object.hh"`
`26`	`26`
	`27`	`+`
	`28`	`+#ifdef _MSC_VER`
	`29`	`+ #pragma warning(push)`
	`30`	`+ // Suppress dll-interface warning. This should no longer be needed in`
	`31`	`+ // gz-rendering9 as visibility changed to hidden by default.`
	`32`	`+ #pragma warning(disable:4251)`
	`33`	`+#endif`
	`34`	`+`
`27`	`35`	`namespace Ogre`
`28`	`36`	`{`
`29`	`37`	`class CompositorWorkspace;`
`@@ -92,4 +100,9 @@ namespace gz`
`92`	`100`	`}`
`93`	`101`	`}`
`94`	`102`	`}`
	`103`	`+`
	`104`	`+#ifdef _MSC_VER`
	`105`	`+ #pragma warning(pop)`
	`106`	`+#endif`
	`107`	`+`
`95`	`108`	`#endif`