Skip to content

Commit 9f7a377

Browse files
authored
Use relative path in an urdf include to avoid confusion between internal and system headers (#1259)
Signed-off-by: Jose Luis Rivero <[email protected]>
1 parent b999425 commit 9f7a377

File tree

7 files changed

+11
-7
lines changed

7 files changed

+11
-7
lines changed

src/urdf/urdf_parser/check_urdf.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
/* Author: Wim Meeussen */
3636
#pragma warning(push, 0)
3737

38-
#include "urdf_parser/urdf_parser.h"
38+
#include "../urdf_parser/urdf_parser.h"
3939
#include <iostream>
4040
#include <fstream>
4141

src/urdf/urdf_parser/joint.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
#include <urdf_model/joint.h>
4242
// #include <console_bridge/console.h>
4343
#include <tinyxml2.h>
44-
#include <urdf_parser/urdf_parser.h>
44+
#include "../urdf_parser/urdf_parser.h"
4545

4646
namespace urdf{
4747

src/urdf/urdf_parser/link.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
/* Author: Wim Meeussen */
3636
#pragma warning(push, 0)
3737

38-
#include <urdf_parser/urdf_parser.h>
38+
#include "../urdf_parser/urdf_parser.h"
3939
#include <urdf_model/link.h>
4040
#include <fstream>
4141
#include <sstream>

src/urdf/urdf_parser/model.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,11 @@
3636
#pragma warning(push, 0)
3737

3838
#include <vector>
39-
#include "urdf_parser/urdf_parser.h"
39+
// Use relative path to avoid confusion with urdf system headers (if present).
40+
// The change to the relative path is only required to be present in this
41+
// file given how MSVC include headers. See:
42+
// https://github.com/gazebosim/sdformat/pull/1259/files#r1149821498
43+
#include "../urdf_parser/urdf_parser.h"
4044
// #include <console_bridge/console.h>
4145
#include <fstream>
4246

src/urdf/urdf_parser/pose.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
#include <algorithm>
4242
// #include <console_bridge/console.h>
4343
#include <tinyxml2.h>
44-
#include <urdf_parser/urdf_parser.h>
44+
#include "../urdf_parser/urdf_parser.h"
4545

4646
namespace urdf_export_helpers {
4747

src/urdf/urdf_parser/urdf_to_graphiz.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
/* Author: Wim Meeussen */
3636
#pragma warning(push, 0)
3737

38-
#include "urdf_parser/urdf_parser.h"
38+
#include "../urdf_parser/urdf_parser.h"
3939
#include <iostream>
4040
#include <fstream>
4141

src/urdf/urdf_parser/world.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737

3838
#include <urdf_world/world.h>
3939
#include <urdf_model/model.h>
40-
#include <urdf_parser/urdf_parser.h>
40+
#include "../urdf_parser/urdf_parser.h"
4141
#include <fstream>
4242
#include <sstream>
4343
#include <algorithm>

0 commit comments

Comments
 (0)