fix: assume that having to create a new transaction state mean it hasn't happened.

This is a workaround, because it will always be false when restarting a node
that has started the transition but not necessarily completed it.

Author: gballet

core/blockchain.go

@@ -1767,8 +1767,6 @@ func (bc *BlockChain) insertChain(chain types.Blocks, setHead bool) (int, error)
 			// is the fork block and that the conversion needs to be marked at started.
 			if !bc.stateCache.InTransition() && !bc.stateCache.Transitioned() {
 				bc.stateCache.StartVerkleTransition(parent.Root, emptyVerkleRoot, bc.Config(), bc.Config().PragueTime, parent.Root)
-			} else {
-				log.Debug("skipped initialization")
 			}
 		}
 		if parent.Number.Uint64() == conversionBlock {

core/state/database.go

@@ -19,7 +19,6 @@ package state
 import (
 	"errors"
 	"fmt"
-	"runtime/debug"
 
 	"github.com/ethereum/go-ethereum/common"
 	"github.com/ethereum/go-ethereum/common/lru"
@@ -238,7 +237,6 @@ func (db *cachingDB) StartVerkleTransition(originalRoot, translatedRoot common.H
 	if pragueTime != nil {
 		chainConfig.PragueTime = pragueTime
 	}
-	debug.PrintStack()
 }
 
 func (db *cachingDB) ReorgThroughVerkleTransition() {
@@ -357,7 +355,6 @@ func (db *cachingDB) OpenTrie(root common.Hash) (Trie, error) {
 		// If the verkle conversion has ended, return a single
 		// verkle trie.
 		if db.CurrentTransitionState.ended {
-			debug.PrintStack()
 			log.Debug("transition ended, returning a simple verkle tree")
 			return vkt, nil
 		}
@@ -570,9 +567,8 @@ func (db *cachingDB) LoadTransitionState(root common.Hash) {
 	ts, ok := db.TransitionStatePerRoot[root]
 	if !ok || ts == nil {
 		log.Debug("could not find any transition state, starting with a fresh state", "is verkle", db.triedb.IsVerkle())
-		debug.PrintStack()
 		// Start with a fresh state
-		ts = &TransitionState{ended: db.triedb.IsVerkle()}
+		ts = &TransitionState{ended: false}
 	}
 
 	// Copy so that the CurrentAddress pointer in the map

eth/catalyst/api.go

@@ -535,10 +535,6 @@ func (api *ConsensusAPI) newPayload(params engine.ExecutableData, versionedHashe
 			api.eth.BlockChain().StartVerkleTransition(parent.Root, common.Hash{}, api.eth.BlockChain().Config(), nil, parent.Root)
 		}
 	}
-	// // Reset db merge state in case of a reorg
-	// if !api.eth.BlockChain().Config().IsPrague(block.Number(), block.Time()) {
-	// 	api.eth.BlockChain().ReorgThroughVerkleTransition()
-	// }
 	// Another cornercase: if the node is in snap sync mode, but the CL client
 	// tries to make it import a block. That should be denied as pushing something
 	// into the database directly will conflict with the assumptions of snap sync