Skip to content

[ENH] Reduce code duplication in AptaTransLightning class #224

@NennoMP

Description

@NennoMP

Currently, there is a some code duplication in AptaTrans lightning trainig code: both classes in aptatrans._model_lightning. Specifically, the logging calls in training_step and test_step are redundant and can be moved to the _step(...) method.

This issue is better addressed when #190 is merged, since tests and some the interface have been slighly changed. The code duplication issue is still relevant though. Therefore parking this for now.

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions