Plugin Incompatible 9/18/2024

[TheGravesGroup]

The plugin is incompatible with the latest Runelite.

I really enjoy this plugin and the extra life it adds to the game. Please fix it! Please :)

[Nick2bad4u]

[flyinglime28]

Yes, any update? Thanks!

[AllanOcelot]

@gc - I've forked this before work and it looks to be a "simple" case of some of your methods being depreciated.

• .getScene()
• .fromWorld()

Being the main ones I can see.

I'm fairly new to Java, but I can have a crack at resolving these after work if you would like?

[gc]

It's not a simple case of things being deprecated. You're welcome to try fix it.

[Nick2bad4u]

It's not a simple case of things being deprecated. You're welcome to try fix it.

Does this mean you're done with the plugin or are still working on it?

[gc]

no i'm not done with it, but I tried hard to fix it and couldn't fix it myself, and i offered money for someone else to fix it and nobody took it. so there's not a whole lot i can do.

[Nick2bad4u]

no i'm not done with it, but I tried hard to fix it and couldn't fix it myself, and i offered money for someone else to fix it and nobody took it. so there's not a whole lot i can do.

hmm... Maybe I can reach out to the runelite plugin development server/channel to see if anyone can help. I'm not versed in runelite plugin coding so if you cannot fix it, I doubt I can learn it enough to fix it in a decent amount of time.

[AllanOcelot]

It's not a simple case of things being deprecated. You're welcome to try fix it.

I'm confused, are you saying you've resolved the deprecated methods and changed over to the new way of doing Tilemaps/Scenes?

If so, can you place your work on a branch so we can see the progress.

[Nick2bad4u]

It's not a simple case of things being deprecated. You're welcome to try fix it.

I'm confused, are you saying you've resolved the deprecated methods and changed over to the new way of doing Tilemaps/Scenes?

If so, can you place your work on a branch so we can see the progress.

I think he's saying he gave it a try and couldn't get it working. Perhaps seeing where he left off would be useful.

I know this broke during the body type update that happened a while back. I'm thinking that's where the problem lies but I haven't even took a look at the code yet.

[gc]

It's not a simple case of things being deprecated. You're welcome to try fix it.

I'm confused, are you saying you've resolved the deprecated methods and changed over to the new way of doing Tilemaps/Scenes?

If so, can you place your work on a branch so we can see the progress.

Something being deprecated doesn't break everything, deprecation just means it's going to be removed later. I haven't heard or seen any deprecations. The issue from my knowledge is entirely due to the update where they added new player models, and needing to account for the increased offset between player kit ids and item model ids, nothing I tried worked. If it's not this, I don't know what it is. There is no progress to share, because I didn't fix it.

[Nick2bad4u]

It's not a simple case of things being deprecated. You're welcome to try fix it.

I'm confused, are you saying you've resolved the deprecated methods and changed over to the new way of doing Tilemaps/Scenes?
If so, can you place your work on a branch so we can see the progress.

Something being deprecated doesn't break everything, deprecation just means it's going to be removed later. I haven't heard or seen any deprecations. The issue from my knowledge is entirely due to the update where they added new player models, and needing to account for the increased offset between player kit ids and item model ids, nothing I tried worked. If it's not this, I don't know what it is. There is no progress to share, because I didn't fix it.

Thats what I figured it was related to as well... Hmm

[kulcris]

I mean it seems to me its a simple matter of changing the IDs models of the NPCs bodies.

seems to be working fine otherwise?

[kulcris]

Just randomly replacing IDs i was able to replace the cape with a chest piece

so if this is the only issue this has its just a matter of going through each and every npc and updating those ids ☠️

           "name": "Emme",
            "examineText": "A protesting H.A.M member.",
            "remarks": [],
            "startScript": "testScript",
            "uuid": "bb076237-1858-42e1-8346-21b5d4f45997",
            "regionId": 12853,
            "entityType": "ScriptedCitizen",
            "worldLocation": {
                "x": 3209,
                "y": 3425,
                "plane": 0
            },
            "modelIds": [
                347, /** Shoulders **/
                353, /** Hands **/
                358,/** Boots **/
                265,  /** Robe Bottom **/
                296, /** Bust **/
                5434, /** Chest Logo **/
                398, /** HEAD **/
                5433, /** Cape Logo2 **/
                317 /** Cape **/
            ],

[gc]

What Ive thought and been told by others, is the model ids in our json files have to reflect the new offset with some math, thats what i tried in every which way and it never looked right. The place I used to get the model ids i think showed that the current ones were right(unless they were out of date which is possible).

[kulcris]

I wonder if it is all IDs after the new "body groups" might be as easy as finding what the new body groups are