Implemented random flok of birds

Author: gcclinux

.kiro/specs/flying-birds-ambient/tasks.md

@@ -58,89 +58,89 @@
   - **Property 12: Horizontal boundary X-coordinate variation**
   - **Validates: Requirements 4.3**
 
-- [ ] 3. Implement V-formation positioning
+- [x] 3. Implement V-formation positioning
   - Implement initializeVFormation() to position 5 birds in V-shape
   - Calculate lead bird position at spawn point
   - Calculate wing bird positions with 40px spacing and 30-degree angle
   - Ensure consistent spacing between all birds in formation
   - _Requirements: 2.2, 2.4_
 
-- [ ] 3.1 Write property test for V-shape arrangement
+- [x] 3.1 Write property test for V-shape arrangement
   - **Property 7: V-shape arrangement**
   - **Validates: Requirements 2.2**
 
-- [ ] 3.2 Write property test for consistent bird spacing
+- [x] 3.2 Write property test for consistent bird spacing
   - **Property 9: Consistent bird spacing**
   - **Validates: Requirements 2.4**
 
-- [ ] 4. Implement flight mechanics
+- [x] 4. Implement flight mechanics
   - Calculate flight direction from spawn boundary to opposite boundary
   - Implement Bird.update() to move bird along velocity vector
   - Implement BirdFormation.update() to update all birds with same velocity
   - Implement hasReachedTarget() to detect when formation crosses opposite boundary
   - _Requirements: 1.3, 1.4, 4.4_
 
-- [ ] 4.1 Write property test for formation reaches opposite boundary
+- [x] 4.1 Write property test for formation reaches opposite boundary
   - **Property 3: Formation reaches opposite boundary**
   - **Validates: Requirements 1.3**
 
-- [ ] 4.2 Write property test for V-shape invariant during flight
+- [x] 4.2 Write property test for V-shape invariant during flight
   - **Property 8: V-shape invariant during flight**
   - **Validates: Requirements 2.3**
 
-- [ ] 4.3 Write property test for flight path toward opposite boundary
+- [x] 4.3 Write property test for flight path toward opposite boundary
   - **Property 13: Flight path toward opposite boundary**
   - **Validates: Requirements 4.4**
 
-- [ ] 5. Implement spawn timer and lifecycle management
+- [x] 5. Implement spawn timer and lifecycle management
   - Implement BirdFormationManager.update() to handle spawn timer countdown
   - Trigger spawnFormation() when timer reaches zero
   - Reset timer with new random interval after spawn
   - Detect when formation reaches target and despawn it
   - Reset spawn timer after despawn
   - _Requirements: 1.1, 1.4, 1.5_
 
-- [ ] 5.1 Write property test for despawn triggers timer reset
+- [x] 5.1 Write property test for despawn triggers timer reset
   - **Property 4: Despawn triggers timer reset**
   - **Validates: Requirements 1.4**
 
-- [ ] 6. Implement rendering system
+- [x] 6. Implement rendering system
   - Load bird sprite texture in BirdFormationManager.initialize()
   - Implement Bird.render() to draw bird sprite at current position
   - Implement BirdFormation.render() to render all 5 birds
   - Implement BirdFormationManager.render() to render active formation only
   - Add null check to skip rendering when no formation is active
   - _Requirements: 3.1, 5.1_
 
-- [ ] 6.1 Write property test for no rendering when not visible
+- [x] 6.1 Write property test for no rendering when not visible
   - **Property 14: No rendering when not visible**
   - **Validates: Requirements 5.1**
 
-- [ ] 7. Implement resource management
+- [x] 7. Implement resource management
   - Implement Bird.dispose() to clean up bird resources
   - Implement BirdFormation.dispose() to dispose all 5 birds
   - Call formation.dispose() when despawning
   - Implement BirdFormationManager.dispose() to clean up shared texture
   - _Requirements: 5.4_
 
-- [ ] 7.1 Write property test for resource cleanup on despawn
+- [x] 7.1 Write property test for resource cleanup on despawn
   - **Property 15: Resource cleanup on despawn**
   - **Validates: Requirements 5.4**
 
-- [ ] 8. Integrate with MyGdxGame
+- [x] 8. Integrate with MyGdxGame
   - Add BirdFormationManager field to MyGdxGame
   - Initialize BirdFormationManager in MyGdxGame.create()
   - Call birdFormationManager.update() in MyGdxGame.render() before rendering
   - Call birdFormationManager.render() after rain effects but before UI elements
   - Call birdFormationManager.dispose() in MyGdxGame.dispose()
   - _Requirements: 3.1, 3.2, 3.3_
 
-- [ ] 9. Create bird sprite asset
+- [x] 9. Create bird sprite asset
   - Create or source a simple bird sprite texture (32x32 pixels recommended)
   - Place texture in assets/sprites/ directory
   - Update Bird class to load texture from correct path
   - Test texture loading and rendering
   - _Requirements: 3.1_
 
-- [ ] 10. Final checkpoint - Ensure all tests pass
+- [x] 10. Final checkpoint - Ensure all tests pass
   - Ensure all tests pass, ask the user if questions arise.

assets/sprites/assets.png

@@ -10,15 +10,25 @@
 public class Bird {
     private float x;
     private float y;
-    private Texture texture;
+    private Texture texture1;
+    private Texture texture2;
     private float animationTime;
+    private static final float ANIMATION_FRAME_DURATION = 0.5f; // 0.5 seconds per frame
 
-    public Bird(float x, float y, Texture texture) {
+    public Bird(float x, float y, Texture texture1, Texture texture2) {
         this.x = x;
         this.y = y;
-        this.texture = texture;
+        this.texture1 = texture1;
+        this.texture2 = texture2;
         this.animationTime = 0f;
     }
+    
+    /**
+     * Legacy constructor for single texture (backwards compatibility)
+     */
+    public Bird(float x, float y, Texture texture) {
+        this(x, y, texture, texture);
+    }
 
     public void update(float deltaTime, Vector2 velocity) {
         this.x += velocity.x * deltaTime;
@@ -27,10 +37,25 @@ public void update(float deltaTime, Vector2 velocity) {
     }
 
     public void render(SpriteBatch batch) {
-        if (texture != null) {
-            batch.draw(texture, x, y);
+        // Alternate between textures based on animation time
+        Texture currentTexture = getCurrentTexture();
+        if (currentTexture != null) {
+            batch.draw(currentTexture, x, y);
         }
     }
+    
+    /**
+     * Get the current texture based on animation time.
+     * Alternates between texture1 and texture2 every 0.5 seconds.
+     */
+    private Texture getCurrentTexture() {
+        if (texture1 == null) return texture2;
+        if (texture2 == null) return texture1;
+        
+        // Calculate which frame we're on (0 or 1)
+        int frame = (int) (animationTime / ANIMATION_FRAME_DURATION) % 2;
+        return frame == 0 ? texture1 : texture2;
+    }
 
     public float getX() {
         return x;

assets/sprites/bird.png

@@ -17,25 +17,32 @@ public class BirdFormation {
     private SpawnBoundary targetBoundary;
     private boolean active;
 
-    public BirdFormation(SpawnPoint spawnPoint, Vector2 velocity, Texture birdTexture) {
+    public BirdFormation(SpawnPoint spawnPoint, Vector2 velocity, Texture birdTexture1, Texture birdTexture2) {
         this.birds = new ArrayList<>();
         this.velocity = velocity;
         this.spawnBoundary = spawnPoint.boundary;
         this.targetBoundary = getOppositeBoundary(spawnPoint.boundary);
         this.active = true;
 
-        initializeVFormation(spawnPoint, birdTexture);
+        initializeVFormation(spawnPoint, birdTexture1, birdTexture2);
+    }
+    
+    /**
+     * Legacy constructor for single texture (backwards compatibility)
+     */
+    public BirdFormation(SpawnPoint spawnPoint, Vector2 velocity, Texture birdTexture) {
+        this(spawnPoint, velocity, birdTexture, birdTexture);
     }
 
-    private void initializeVFormation(SpawnPoint spawnPoint, Texture birdTexture) {
+    private void initializeVFormation(SpawnPoint spawnPoint, Texture birdTexture1, Texture birdTexture2) {
         // V-formation with 1 lead bird and 2 birds on each wing
         // Formation angle: 30 degrees, spacing: 40 pixels
 
         float leadX = spawnPoint.x;
         float leadY = spawnPoint.y;
 
         // Lead bird at the front
-        birds.add(new Bird(leadX, leadY, birdTexture));
+        birds.add(new Bird(leadX, leadY, birdTexture1, birdTexture2));
 
         // Calculate perpendicular direction for wing positioning
         Vector2 perpendicular = new Vector2(-spawnPoint.direction.y, spawnPoint.direction.x);
@@ -48,14 +55,14 @@ private void initializeVFormation(SpawnPoint spawnPoint, Texture birdTexture) {
         for (int i = 1; i <= 2; i++) {
             float offsetX = perpendicular.x * spacing * i - spawnPoint.direction.x * backwardOffset * i;
             float offsetY = perpendicular.y * spacing * i - spawnPoint.direction.y * backwardOffset * i;
-            birds.add(new Bird(leadX + offsetX, leadY + offsetY, birdTexture));
+            birds.add(new Bird(leadX + offsetX, leadY + offsetY, birdTexture1, birdTexture2));
         }
 
         // Right wing (2 birds)
         for (int i = 1; i <= 2; i++) {
             float offsetX = -perpendicular.x * spacing * i - spawnPoint.direction.x * backwardOffset * i;
             float offsetY = -perpendicular.y * spacing * i - spawnPoint.direction.y * backwardOffset * i;
-            birds.add(new Bird(leadX + offsetX, leadY + offsetY, birdTexture));
+            birds.add(new Bird(leadX + offsetX, leadY + offsetY, birdTexture1, birdTexture2));
         }
     }
 
@@ -81,29 +88,34 @@ public void render(SpriteBatch batch) {
         }
     }
 
-    public boolean hasReachedTarget(float viewWidth, float viewHeight) {
+    public boolean hasReachedTarget(float viewWidth, float viewHeight, float cameraX, float cameraY) {
         if (birds.isEmpty()) {
             return false;
         }
 
-        // Check lead bird position against target boundary
+        // Check lead bird position against target boundary (camera-relative)
         Bird leadBird = birds.get(0);
         float x = leadBird.getX();
         float y = leadBird.getY();
 
         switch (targetBoundary) {
             case TOP:
-                return y > viewHeight;
+                return y > cameraY + viewHeight;
             case BOTTOM:
-                return y < 0;
+                return y < cameraY;
             case LEFT:
-                return x < 0;
+                return x < cameraX;
             case RIGHT:
-                return x > viewWidth;
+                return x > cameraX + viewWidth;
             default:
                 return false;
         }
     }
+    
+    // Backward compatibility method for tests
+    public boolean hasReachedTarget(float viewWidth, float viewHeight) {
+        return hasReachedTarget(viewWidth, viewHeight, 0, 0);
+    }
 
     public void dispose() {
         for (Bird bird : birds) {