Skip to content

Commit 20c3e01

Browse files
author
Yushu.Kozaki
committed
refactor: change existing var names for GAE
1 parent c86a7f1 commit 20c3e01

File tree

3 files changed

+17
-17
lines changed

3 files changed

+17
-17
lines changed

constant.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@ package gcpen
33
const (
44
EnvKeyProjectID = "GCP_PROJECT" // for Google Cloud Functions
55
EnvKeyGoogleCloudProject = "GOOGLE_CLOUD_PROJECT" // for Google App Engine
6-
EnvKeyServiceName = "GAE_SERVICE" // for Google App Engine
7-
EnvKeyServiceVersion = "GAE_VERSION" // for Google App Engine
6+
EnvKeyGAEServiceName = "GAE_SERVICE" // for Google App Engine
7+
EnvKeyGAEServiceVersion = "GAE_VERSION" // for Google App Engine
88
)

environ.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ import (
77
var (
88
// ProjectID - Google Cloud Platform Project ID
99
ProjectID = getProjectID()
10-
// ServiceName - Google App Engine service name
11-
ServiceName = os.Getenv(EnvKeyServiceName)
12-
// ServiceVersion - Google App Engine service version
13-
ServiceVersion = os.Getenv(EnvKeyServiceVersion)
10+
// GAEServiceName - Google App Engine service name
11+
GAEServiceName = os.Getenv(EnvKeyGAEServiceName)
12+
// GAEServiceVersion - Google App Engine service version
13+
GAEServiceVersion = os.Getenv(EnvKeyGAEServiceVersion)
1414
)
1515

1616
func getProjectID() string {
@@ -30,6 +30,6 @@ func getProjectID() string {
3030
// Reload - Reload environment variables.
3131
func Reload() {
3232
ProjectID = getProjectID()
33-
ServiceName = os.Getenv(EnvKeyServiceName)
34-
ServiceVersion = os.Getenv(EnvKeyServiceVersion)
33+
GAEServiceName = os.Getenv(EnvKeyGAEServiceName)
34+
GAEServiceVersion = os.Getenv(EnvKeyGAEServiceVersion)
3535
}

environ_test.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,26 +6,26 @@ import (
66
)
77

88
const (
9-
testProject = "test-project"
10-
testService = "test-service"
11-
testVersion = "test-version"
9+
testProject = "test-project"
10+
testGAEService = "test-gae-service"
11+
testGAEVersion = "test-gae-version"
1212
)
1313

1414
func init() {
1515
os.Setenv(EnvKeyGoogleCloudProject, testProject)
16-
os.Setenv(EnvKeyServiceName, testService)
17-
os.Setenv(EnvKeyServiceVersion, testVersion)
16+
os.Setenv(EnvKeyGAEServiceName, testGAEService)
17+
os.Setenv(EnvKeyGAEServiceVersion, testGAEVersion)
1818
}
1919

2020
func TestEnviron(t *testing.T) {
2121
Reload()
2222
if ProjectID != testProject {
2323
t.Fatalf("unexpected, expected: %s, actual: %#v", testProject, ProjectID)
2424
}
25-
if ServiceName != testService {
26-
t.Fatalf("unexpected, expected: %s, actual: %#v", testService, ServiceName)
25+
if GAEServiceName != testGAEService {
26+
t.Fatalf("unexpected, expected: %s, actual: %#v", testGAEService, GAEServiceName)
2727
}
28-
if ServiceVersion != testVersion {
29-
t.Fatalf("unexpected, expected: %s, actual: %#v", testVersion, ServiceVersion)
28+
if GAEServiceVersion != testGAEVersion {
29+
t.Fatalf("unexpected, expected: %s, actual: %#v", testGAEVersion, GAEServiceVersion)
3030
}
3131
}

0 commit comments

Comments
 (0)