Skip to content

Commit 13ab6ab

Browse files
committed
hotfix: forgot to wrap the response writer
1 parent 2d348c3 commit 13ab6ab

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

middleware.go

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ func RequestLogging(config *Config) func(http.Handler) http.Handler {
6161
func RequestLoggingWithEcho(config *Config) echo.MiddlewareFunc {
6262
return func(next echo.HandlerFunc) echo.HandlerFunc {
6363
fn := func(c echo.Context) error {
64+
before := time.Now()
6465
r := c.Request()
6566
traceId := getTraceId(r)
6667
if traceId == "" {
@@ -84,6 +85,18 @@ func RequestLoggingWithEcho(config *Config) echo.MiddlewareFunc {
8485

8586
r = r.WithContext(ctx)
8687
c.SetRequest(r)
88+
89+
w := c.Response().Writer
90+
wrw := &wrappedResponseWriter{ResponseWriter: w}
91+
defer func() {
92+
// logging
93+
elapsed := time.Since(before)
94+
maxSeverity := contextLogger.maxSeverity()
95+
err := writeRequestLog(r, config, wrw.status, wrw.responseSize, elapsed, traces, maxSeverity)
96+
if err != nil {
97+
_, _ = fmt.Fprintln(os.Stderr, err.Error())
98+
}
99+
}()
87100
return next(c)
88101
}
89102
return fn

0 commit comments

Comments
 (0)