Merge pull request #202 from theraot/bugfix

NathanLovato · web-flow · commit 17dae66f913d · 2021-02-07T22:20:37.000-06:00
Use drop chance correctly
diff --git a/godot/src/combat/Rewards.gd b/godot/src/combat/Rewards.gd
@@ -24,7 +24,7 @@ func _add_reward(battler: Battler):
 	# Appends dictionaries with the form { 'item': Item.tres, 'amount': amount } of dropped items to the drops array.
 	experience_earned += battler.drops.experience
 	for drop in battler.drops.get_drops():
-		if drop.chance - randf() > drop.chance:
+		if drop.chance < 1 and randf() >= drop.chance:
 			continue
 		var amount: int = (
 			1

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ func _add_reward(battler: Battler):`
`24`	`24`	`# Appends dictionaries with the form { 'item': Item.tres, 'amount': amount } of dropped items to the drops array.`
`25`	`25`	`experience_earned += battler.drops.experience`
`26`	`26`	`for drop in battler.drops.get_drops():`
`27`		`- if drop.chance - randf() > drop.chance:`
	`27`	`+ if drop.chance < 1 and randf() >= drop.chance:`
`28`	`28`	`continue`
`29`	`29`	`var amount: int = (`
`30`	`30`	`1`