[CHORE] Add NLB tests (oracle#48)

Author: shopewf

src/oci-network-load-balancer-mcp-server/oracle/oci_network_load_balancer_mcp_server/server.py

@@ -6,11 +6,11 @@
 
 logger = Logger(__name__, level="INFO")
 
-mcp = FastMCP(name="oracle.oci-compute-mcp-server")
+mcp = FastMCP(name="oracle.oci-network-load-balancer-mcp-server")
 
 
-def get_network_load_balancer_client():
-    logger.info("entering get_network_load_balancer_client")
+def get_nlb_client():
+    logger.info("entering get_nlb_client")
     config = oci.config.from_file(
         profile_name=os.getenv("OCI_CONFIG_PROFILE", oci.config.DEFAULT_PROFILE)
     )
@@ -25,9 +25,9 @@ def get_network_load_balancer_client():
 
 
 @mcp.tool
-def list_network_load_balancers(compartment_id: str):
+def list_network_load_balancers(compartment_id: str) -> list[dict]:
     """Lists the network load balancers from the given compartment"""
-    nlb_client = get_network_load_balancer_client()
+    nlb_client = get_nlb_client()
     nlbs = nlb_client.list_network_load_balancers(compartment_id).data.items
     return [
         {
@@ -46,14 +46,14 @@ def list_network_load_balancers(compartment_id: str):
 @mcp.tool
 def get_network_load_balancer(network_load_balancer_id: str):
     """Gets the network load balancer with the given ocid"""
-    nlb_client = get_network_load_balancer_client()
+    nlb_client = get_nlb_client()
     return nlb_client.get_network_load_balancer(network_load_balancer_id).data
 
 
 @mcp.tool(name="list_network_load_balancer_listeners")
-def list_listeners(network_load_balancer_id: str):
+def list_listeners(network_load_balancer_id: str) -> list[dict]:
     """Lists the listeners from the given network load balancer"""
-    nlb_client = get_network_load_balancer_client()
+    nlb_client = get_nlb_client()
     listeners = nlb_client.list_listeners(network_load_balancer_id).data.items
     return [
         {
@@ -74,14 +74,14 @@ def get_listener(
 ):
     """Gets the listener with the given listener name
     from the given network load balancer"""
-    nlb_client = get_network_load_balancer_client()
+    nlb_client = get_nlb_client()
     return nlb_client.get_listener(network_load_balancer_id, listener_name).data
 
 
 @mcp.tool(name="list_network_load_balancer_backend_sets")
-def list_backend_sets(network_load_balancer_id: str):
+def list_backend_sets(network_load_balancer_id: str) -> list[dict]:
     """Lists the backend sets from the given network load balancer"""
-    nlb_client = get_network_load_balancer_client()
+    nlb_client = get_nlb_client()
     backend_sets = nlb_client.list_backend_sets(network_load_balancer_id).data.items
     return [
         {
@@ -102,17 +102,17 @@ def get_backend_set(
 ):
     """Gets the backend set with the given backend set name
     from the given network load balancer"""
-    nlb_client = get_network_load_balancer_client()
+    nlb_client = get_nlb_client()
     return nlb_client.get_backend_set(network_load_balancer_id, backend_set_name).data
 
 
 @mcp.tool(name="list_network_load_balancer_backends")
 def list_backends(
     network_load_balancer_id: str,
     backend_set_name: str,
-):
+) -> list[dict]:
     """Lists the backends from the given backend set and network load balancer"""
-    nlb_client = get_network_load_balancer_client()
+    nlb_client = get_nlb_client()
     backends = nlb_client.list_backends(
         network_load_balancer_id, backend_set_name
     ).data.items
@@ -138,7 +138,7 @@ def get_backend(
 ):
     """Gets the backend with the given backend name
     from the given backend set and network load balancer"""
-    nlb_client = get_network_load_balancer_client()
+    nlb_client = get_nlb_client()
     return nlb_client.get_backend(
         network_load_balancer_id, backend_set_name, backend_name
     ).data

src/oci-network-load-balancer-mcp-server/oracle/oci_network_load_balancer_mcp_server/tests/test_network_load_balancer_tools.py

@@ -0,0 +1,145 @@
+from unittest.mock import MagicMock, create_autospec, patch
+
+import oci
+import pytest
+from fastmcp import Client
+from oracle.oci_network_load_balancer_mcp_server.server import mcp
+
+
+class TestNlbTools:
+    @pytest.mark.asyncio
+    @patch("oracle.oci_network_load_balancer_mcp_server.server.get_nlb_client")
+    async def test_list_nlbs(self, mock_get_client):
+        mock_client = MagicMock()
+        mock_get_client.return_value = mock_client
+
+        mock_list_response = create_autospec(oci.response.Response)
+        mock_list_response.data = (
+            oci.network_load_balancer.models.NetworkLoadBalancerCollection(
+                items=[
+                    oci.network_load_balancer.models.NetworkLoadBalancerSummary(
+                        id="nlb1",
+                        display_name="NLB 1",
+                        lifecycle_state="ACTIVE",
+                        ip_addresses=[
+                            oci.network_load_balancer.models.IpAddress(
+                                ip_address="192.168.1.1", is_public=True
+                            ),
+                            oci.network_load_balancer.models.IpAddress(
+                                ip_address="10.0.0.0", is_public=False
+                            ),
+                        ],
+                    )
+                ]
+            )
+        )
+        mock_client.list_network_load_balancers.return_value = mock_list_response
+
+        async with Client(mcp) as client:
+            result = (
+                await client.call_tool(
+                    "list_network_load_balancers",
+                    {"compartment_id": "test_compartment"},
+                )
+            ).structured_content["result"]
+
+            assert len(result) == 1
+            assert result[0]["nlb_id"] == "nlb1"
+
+    @pytest.mark.asyncio
+    @patch("oracle.oci_network_load_balancer_mcp_server.server.get_nlb_client")
+    async def test_list_listeners(self, mock_get_client):
+        mock_client = MagicMock()
+        mock_get_client.return_value = mock_client
+
+        mock_list_response = create_autospec(oci.response.Response)
+        mock_list_response.data = oci.network_load_balancer.models.ListenerCollection(
+            items=[
+                oci.network_load_balancer.models.ListenerSummary(
+                    name="Listener 1",
+                    ip_version="IPV4",
+                    protocol="HTTP",
+                    port=8008,
+                    is_ppv2_enabled=False,
+                )
+            ]
+        )
+        mock_client.list_listeners.return_value = mock_list_response
+
+        async with Client(mcp) as client:
+            result = (
+                await client.call_tool(
+                    "list_network_load_balancer_listeners",
+                    {"network_load_balancer_id": "test_nlb"},
+                )
+            ).structured_content["result"]
+
+            assert len(result) == 1
+            assert result[0]["name"] == "Listener 1"
+
+    @pytest.mark.asyncio
+    @patch("oracle.oci_network_load_balancer_mcp_server.server.get_nlb_client")
+    async def test_list_backend_sets(self, mock_get_client):
+        mock_client = MagicMock()
+        mock_get_client.return_value = mock_client
+
+        mock_list_response = create_autospec(oci.response.Response)
+        mock_list_response.data = oci.network_load_balancer.models.BackendSetCollection(
+            items=[
+                oci.network_load_balancer.models.BackendSetSummary(
+                    name="Backend Set 1",
+                    ip_version="IPV4",
+                    are_operationally_active_backends_preferred=False,
+                    policy="3-TUPLE",
+                    backends=[],
+                )
+            ]
+        )
+        mock_client.list_backend_sets.return_value = mock_list_response
+
+        async with Client(mcp) as client:
+            result = (
+                await client.call_tool(
+                    "list_network_load_balancer_backend_sets",
+                    {"network_load_balancer_id": "test_nlb"},
+                )
+            ).structured_content["result"]
+
+            assert len(result) == 1
+            assert result[0]["name"] == "Backend Set 1"
+
+    @pytest.mark.asyncio
+    @patch("oracle.oci_network_load_balancer_mcp_server.server.get_nlb_client")
+    async def test_list_backends(self, mock_get_client):
+        mock_client = MagicMock()
+        mock_get_client.return_value = mock_client
+
+        mock_list_response = create_autospec(oci.response.Response)
+        mock_list_response.data = oci.network_load_balancer.models.BackendCollection(
+            items=[
+                oci.network_load_balancer.models.BackendSummary(
+                    name="Backend 1",
+                    ip_address="192.168.1.1",
+                    port=8008,
+                    weight=0,
+                    is_drain=False,
+                    is_backup=False,
+                    is_offline=False,
+                )
+            ]
+        )
+        mock_client.list_backends.return_value = mock_list_response
+
+        async with Client(mcp) as client:
+            result = (
+                await client.call_tool(
+                    "list_network_load_balancer_backends",
+                    {
+                        "network_load_balancer_id": "test_nlb",
+                        "backend_set_name": "test_backend_set",
+                    },
+                )
+            ).structured_content["result"]
+
+            assert len(result) == 1
+            assert result[0]["name"] == "Backend 1"

src/oci-network-load-balancer-mcp-server/pyproject.toml

@@ -21,3 +21,9 @@ build-backend = "hatchling.build"
 
 [tool.hatch.build.targets.wheel]
 packages = ["oracle"]
+
+[dependency-groups]
+dev = [
+    "pytest>=8.4.2",
+    "pytest-asyncio>=1.2.0",
+]