Create new database clusuters on every test run

The cost of running initdb, especially without fsync, is not very big on
modern computers and version of PostgreSQL so the optimization of
reusing the same database cluster between test runs is just a potential
footgun no longer worth the benefits.

It might still be worth caching the generated TLS certificates but for
now let's not do that to keep the code simple.

Author: jeltz

spec/helpers.rb

@@ -251,7 +251,6 @@ def initialize(name, port: 23456, postgresql_conf: '')
 
 		def create_test_db
 			trace "Creating the test DB"
-			log_and_run @logfile, pg_bin_path('psql'), '-p', @port.to_s, '-e', '-c', 'DROP DATABASE IF EXISTS test', 'postgres'
 			log_and_run @logfile, pg_bin_path('createdb'), '-p', @port.to_s, '-e', 'test'
 		end
 
@@ -276,12 +275,10 @@ def ca_file
 		private
 
 		def setup_cluster(postgresql_conf)
-			return if (@pgdata+"ruby-pg-server-cert").exist?
-
 			FileUtils.rm_rf(@pgdata, verbose: $DEBUG)
 
 			trace "Running initdb"
-			log_and_run @logfile, pg_bin_path('initdb'), '-E', 'UTF8', '--no-locale', '-D', @pgdata.to_s
+			log_and_run @logfile, pg_bin_path('initdb'), '-E', 'UTF8', '--no-locale', '--no-sync', '-D', @pgdata.to_s
 
 			trace "Enable SSL"
 			# Enable SSL in server config